Chromium Code Reviews| Index: chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc |
| diff --git a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc b/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc |
| index b8b61816986ae08fd17623393b2d92d3a207a801..ac6ab9e388eed3e9bb59e4be13d762311e644c0d 100644 |
| --- a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc |
| +++ b/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc |
| @@ -823,7 +823,7 @@ class ChromeLauncherControllerImplTest : public BrowserWithTestWindowTest { |
| std::vector<arc::mojom::AppInfo>()); |
| } |
| - void EnableArc(bool enabled) { |
| + void EnablePlay(bool enabled) { |
|
hidehiko
2017/02/23 10:29:17
Maybe TODO to test with PARC?
victorhsieh
2017/02/24 00:45:00
Done. I didn't realize many of these tests need r
|
| arc_test_.arc_session_manager()->SetArcPlayStoreEnabled(enabled); |
| base::RunLoop().RunUntilIdle(); |
| } |
| @@ -1336,7 +1336,7 @@ TEST_F(ChromeLauncherControllerImplWithArcTest, |
| EXPECT_EQ(0U, app_service_->sync_items().size()); |
| // Move back to ARC disabled platform. |
| - EnableArc(false); |
| + EnablePlay(false); |
| StartAppSyncService(copy_sync_list); |
| RecreateChromeLauncher(); |
| @@ -1352,7 +1352,7 @@ TEST_F(ChromeLauncherControllerImplWithArcTest, |
| model_->Move(4, 2); |
| launcher_controller_->UnpinAppWithID(extension2_->id()); |
| EXPECT_EQ("AppList, App3, Chrome, App1", GetPinnedAppStatus()); |
| - EnableArc(true); |
| + EnablePlay(true); |
| SendListOfArcApps(); |
| @@ -2091,9 +2091,9 @@ TEST_F(ChromeLauncherControllerImplWithArcTest, ArcAppPin) { |
| EXPECT_EQ("AppList, Chrome, App1, App2, Fake App 0", GetPinnedAppStatus()); |
| // Opt-Out/Opt-In remove item from the shelf. |
| - EnableArc(false); |
| + EnablePlay(false); |
| EXPECT_EQ("AppList, Chrome, App1, App2", GetPinnedAppStatus()); |
| - EnableArc(true); |
| + EnablePlay(true); |
| EXPECT_EQ("AppList, Chrome, App1, App2", GetPinnedAppStatus()); |
| SendListOfArcApps(); |
| EXPECT_EQ("AppList, Chrome, App1, App2, Fake App 0", GetPinnedAppStatus()); |
| @@ -2124,7 +2124,7 @@ TEST_F(ChromeLauncherControllerImplWithArcTest, ArcAppPinOptOutOptIn) { |
| EXPECT_EQ("AppList, Chrome, App1, Fake App 1, App2, Fake App 0", |
| GetPinnedAppStatus()); |
| - EnableArc(false); |
| + EnablePlay(false); |
| EXPECT_EQ("AppList, Chrome, App1, App2", GetPinnedAppStatus()); |
| EXPECT_TRUE(launcher_controller_->IsAppPinned(extension1_->id())); |
| @@ -2132,7 +2132,7 @@ TEST_F(ChromeLauncherControllerImplWithArcTest, ArcAppPinOptOutOptIn) { |
| EXPECT_TRUE(launcher_controller_->IsAppPinned(extension2_->id())); |
| EXPECT_FALSE(launcher_controller_->IsAppPinned(arc_app_id2)); |
| - EnableArc(true); |
| + EnablePlay(true); |
| SendListOfArcApps(); |
| base::RunLoop().RunUntilIdle(); |
| @@ -3577,7 +3577,7 @@ TEST_F(ChromeLauncherControllerImplWithArcTest, ArcAppPinPolicy) { |
| TEST_F(ChromeLauncherControllerImplWithArcTest, ArcManaged) { |
| extension_service_->AddExtension(arc_support_host_.get()); |
| // Test enables ARC, so turn it off for initial values. |
| - EnableArc(false); |
| + EnablePlay(false); |
| InitLauncherController(); |
| @@ -3616,19 +3616,19 @@ TEST_F(ChromeLauncherControllerImplWithArcTest, ArcManaged) { |
| "AppList, Chrome, Play Store"); |
| // ARC is not managed and enabled, Play Store pin should be available. |
| - EnableArc(true); |
| + EnablePlay(true); |
| ValidateArcState(true, false, |
| arc::ArcSessionManager::State::SHOWING_TERMS_OF_SERVICE, |
| "AppList, Chrome, Play Store"); |
| // User disables ARC. ARC is not managed and disabled, Play Store pin should |
| // be automatically removed. |
| - EnableArc(false); |
| + EnablePlay(false); |
| ValidateArcState(false, false, arc::ArcSessionManager::State::STOPPED, |
| "AppList, Chrome"); |
| // Even if re-enable it again, Play Store pin does not appear automatically. |
| - EnableArc(true); |
| + EnablePlay(true); |
| ValidateArcState(true, false, |
| arc::ArcSessionManager::State::SHOWING_TERMS_OF_SERVICE, |
| "AppList, Chrome"); |
| @@ -3733,7 +3733,7 @@ TEST_F(ChromeLauncherControllerOrientationTest, |
| ASSERT_TRUE(display::Display::HasInternalDisplay()); |
| extension_service_->AddExtension(arc_support_host_.get()); |
| - EnableArc(true); |
| + EnablePlay(true); |
| InitLauncherController(); |
| arc::ArcSessionManager::SetShelfDelegateForTesting( |
| @@ -3784,7 +3784,7 @@ TEST_F(ChromeLauncherControllerOrientationTest, ArcOrientationLock) { |
| ASSERT_TRUE(display::Display::HasInternalDisplay()); |
| extension_service_->AddExtension(arc_support_host_.get()); |
| - EnableArc(true); |
| + EnablePlay(true); |
| EnableTabletMode(true); |
| InitLauncherController(); |
| @@ -3883,7 +3883,7 @@ TEST_F(ChromeLauncherControllerOrientationTest, CurrentWithLandscapeDisplay) { |
| ASSERT_TRUE(display::Display::HasInternalDisplay()); |
| extension_service_->AddExtension(arc_support_host_.get()); |
| - EnableArc(true); |
| + EnablePlay(true); |
| EnableTabletMode(true); |
| InitLauncherController(); |
| @@ -3950,7 +3950,7 @@ TEST_F(ChromeLauncherControllerArcDefaultAppsTest, DefaultApps) { |
| launcher_controller_.get()); |
| ArcAppListPrefs* const prefs = arc_test_.arc_app_list_prefs(); |
| - EnableArc(false); |
| + EnablePlay(false); |
| EXPECT_FALSE(arc_test_.arc_session_manager()->IsArcPlayStoreEnabled()); |
| ASSERT_TRUE(prefs->GetAppIds().size()); |
| @@ -3964,7 +3964,7 @@ TEST_F(ChromeLauncherControllerArcDefaultAppsTest, DefaultApps) { |
| launcher_controller_->GetShelfIDForAppID(app_id)); |
| // Stop ARC again. Shelf item should go away. |
| - EnableArc(false); |
| + EnablePlay(false); |
| EXPECT_EQ(ash::kInvalidShelfID, |
| launcher_controller_->GetShelfIDForAppID(app_id)); |