Start ARC and sign in after Chrome OS login

chrome/browser/chromeos/arc/arc_session_manager.h

Index: chrome/browser/chromeos/arc/arc_session_manager.h
diff --git a/chrome/browser/chromeos/arc/arc_session_manager.h b/chrome/browser/chromeos/arc/arc_session_manager.h
index 227c59370e16fa45d1345e202cb5c27035c50394..ed1a4fe4d8c852d30d9cca4a390a9b8f6b69b9b8 100644
--- a/chrome/browser/chromeos/arc/arc_session_manager.h
+++ b/chrome/browser/chromeos/arc/arc_session_manager.h
@@ -121,7 +121,9 @@ class ArcSessionManager : public ArcSessionObserver,
   static void SetShelfDelegateForTesting(ash::ShelfDelegate* shelf_delegate);
   static void EnableCheckAndroidManagementForTesting();
 
-  // Returns true if ARC is allowed to run for the current session.
+  // Returns true if Persistent ARC is enabled.
+  static bool IsPersistentArc();

[Yusuke Sato, 2017/02/23 00:47:13]

I haven't reviewed this CL in detail yet, but the word Persistent ARC seems a
bit too broad here because it is a project name that consists of a series of
features. Also, developers who are not familiar with the project won't
immediately get the meaning. The word "persistent" may also give a wrong
impression that the instance will outlive the user session when
IsPersistentArc() is true.

Could you use a little bit more specific function name (and flag name) for this?
As we chatted off line, what about something like ShouldAlwaysStartArc()?

hidehiko@, WDYT? Any preference on this?

[hidehiko, 2017/02/23 10:29:16]

Makes sense. Another candidate is ShouldAlwaysRunArc()?
Also, IMHO, it'd be nice if the flag name is also consistent with the function
name somehow.


Could you move this into components/arc/arc_util?

[hidehiko, 2017/02/23 10:30:54]

a bit bikeshedding: To be consistent with helper functions in arc_util, maybe
ShouldArc...() looks better?

[victorhsieh, 2017/02/24 00:44:59]

Done.

+
   // TODO(hidehiko): The name is very close to IsArcAllowedForProfile(), but
   // has different meaning. Clean this up.
   bool IsAllowed() const;
@@ -252,6 +254,7 @@ class ArcSessionManager : public ArcSessionObserver,
   void PrepareContextForAuthCodeRequest();
 
   void StartArcAndroidManagementCheck();
+  void StartArcAndroidManagementCheckedInBackground();
   void MaybeReenableArc();
 
   // Called when the Android management check is done in opt-in flow or