Start ARC and sign in after Chrome OS login

chromeos/chromeos_switches.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromeos/chromeos_switches.h"
 
 #include <string>
 
 #include "base/command_line.h"
 #include "base/metrics/field_trial.h"
@@ skipping 37 matching lines @@
 // tests don't have to mock out the policy infrastructure.
 const char kAllowFailedPolicyFetchForTest[] =
     "allow-failed-policy-fetch-for-test";
 
 // Allows remote attestation (RA) in dev mode for testing purpose. Usually RA
 // is disabled in dev mode because it will always fail. However, there are cases
 // in testing where we do want to go through the permission flow even in dev
 // mode. This can be enabled by this flag.
 const char kAllowRAInDevMode[] = "allow-ra-in-dev-mode";
 
+// Always starts ARC after login screen without Play Store, not only for primary

[Luis Héctor Chávez, 2017/02/27 17:13:15]

nit: we can make the wording stronger: "Always starts ARC after login screen
without Play Store. This still requires that both the hardware and
account/profile supports starting ARC." that way we tie it to normal ARC support
and don't have to update the wording every time we add support for more modes
(like AD auth).

[victorhsieh, 2017/02/28 18:57:33]

Actually, ARC will run without account/profile.  We will only have exception
case when ARC won't run, possibly including secondary profile.  Let me reword.

+// account, but also in most of the session such as Kiosk mode and guest mode.
+// Node that secondary account won't be supported. Play Store opt-in is still
+// required for user's account.
+const char kAlwaysStartArc[] = "always-start-arc";

[Luis Héctor Chávez, 2017/02/27 17:13:15]

for consistency with all the other ARC flags, can this be "arc-start-always"?
(even other non-ARC flags also seem to follow the convention of
kComponentFlag... or kDisableComponentFlag...)

[victorhsieh, 2017/02/28 18:57:33]

Done.  Also renamed the functions accordingly.

+
 // Specifies whether an app launched in kiosk mode was auto launched with zero
 // delay. Used in order to properly restore auto-launched state during session
 // restore flow.
 const char kAppAutoLaunched[] = "app-auto-launched";
 
 // Path for app's OEM manifest file.
 const char kAppOemManifestFile[] = "app-mode-oem-manifest";
 
 // Signals ARC support status on this device. This can take one of the
 // following three values.
@@ skipping 435 matching lines @@
   base::CommandLine* command_line = base::CommandLine::ForCurrentProcess();
   if (!command_line->HasSwitch(kTestCrosGaiaIdMigration))
     return false;
 
   return command_line->GetSwitchValueASCII(kTestCrosGaiaIdMigration) ==
          kTestCrosGaiaIdMigrationStarted;
 }
 
 }  // namespace switches
 }  // namespace chromeos