Start ARC and sign in after Chrome OS login

chrome/browser/ui/app_list/arc/arc_app_utils.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/app_list/arc/arc_app_utils.h"
 
 #include <memory>
 #include <string>
 
 #include "ash/shell.h"
 #include "base/bind.h"
 #include "base/json/json_writer.h"
 #include "base/synchronization/waitable_event.h"
 #include "base/values.h"
 #include "chrome/browser/chromeos/arc/arc_util.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/app_list/arc/arc_app_list_prefs.h"
 #include "chrome/browser/ui/ash/launcher/arc_app_deferred_launcher_controller.h"
 #include "chrome/browser/ui/ash/launcher/arc_app_shelf_id.h"
 #include "chrome/browser/ui/ash/launcher/chrome_launcher_controller.h"
 #include "chromeos/dbus/dbus_thread_manager.h"
 #include "chromeos/dbus/session_manager_client.h"
 #include "components/arc/arc_bridge_service.h"
 #include "components/arc/arc_service_manager.h"
+#include "components/arc/arc_util.h"
 #include "components/arc/common/intent_helper.mojom.h"
 #include "ui/aura/window.h"
 #include "ui/display/display.h"
 #include "ui/display/screen.h"
 #include "ui/events/event_constants.h"
 
 // Helper macro which returns the AppInstance.
 #define GET_APP_INSTANCE(method_name)                                    \
   (arc::ArcServiceManager::Get()                                         \
        ? ARC_GET_INSTANCE_FOR_METHOD(                                    \
@@ skipping 225 matching lines @@
 }
 
 bool LaunchApp(content::BrowserContext* context,
                const std::string& app_id,
                bool landscape_layout,
                int event_flags) {
   ArcAppListPrefs* prefs = ArcAppListPrefs::Get(context);
   std::unique_ptr<ArcAppListPrefs::AppInfo> app_info = prefs->GetApp(app_id);
   if (app_info && !app_info->ready) {
     Profile* profile = Profile::FromBrowserContext(context);
-    bool play_store_activated = false;
+
     if (!IsArcPlayStoreEnabledForProfile(profile)) {
-      if (!prefs->IsDefault(app_id)) {
-        NOTREACHED();
-        return false;
+      if (prefs->IsDefault(app_id)) {
+        SetArcPlayStoreEnabledForProfile(profile, true);
+        if (!IsArcPlayStoreEnabledForProfile(profile)) {

[Luis Héctor Chávez, 2017/03/01 22:25:39]

This is the same condition as L272, so this will always be true if you hit this.

[victorhsieh, 2017/03/02 00:28:12]

No, the previous line switches it.  I don't know why we need to double check
though.

+          NOTREACHED();
+          return false;
+        }
+
+        // PlayStore item has special handling for shelf controllers. In order
+        // to avoid unwanted initial animation for PlayStore item do not create
+        // deferred launch request when PlayStore item enables Google Play
+        // Store.
+        if (app_id == kPlayStoreAppId) {
+          prefs->SetLastLaunchTime(app_id, base::Time::Now());
+          return true;
+        }
+      } else {
+        if (!arc::ShouldArcAlwaysStart()) {
+          NOTREACHED();
+          return false;
+        }
       }
-
-      SetArcPlayStoreEnabledForProfile(profile, true);
-      if (!IsArcPlayStoreEnabledForProfile(profile)) {
-        NOTREACHED();
-        return false;
-      }
-      play_store_activated = true;
     }
 
-    // PlayStore item has special handling for shelf controllers. In order to
-    // avoid unwanted initial animation for PlayStore item do not create
-    // deferred launch request when PlayStore item enables Google Play Store.
-    if (!play_store_activated || app_id != kPlayStoreAppId) {
-      ChromeLauncherController* chrome_controller =
-          ChromeLauncherController::instance();
-      DCHECK(chrome_controller || !ash::Shell::HasInstance());
-      if (chrome_controller) {
-        chrome_controller->GetArcDeferredLauncher()->RegisterDeferredLaunch(
-            app_id, event_flags);
+    ChromeLauncherController* chrome_controller =
+        ChromeLauncherController::instance();
+    DCHECK(chrome_controller || !ash::Shell::HasInstance());
+    if (chrome_controller) {
+      chrome_controller->GetArcDeferredLauncher()->RegisterDeferredLaunch(
+          app_id, event_flags);
 
-        // On some boards, ARC is booted with a restricted set of resources by
-        // default to avoid slowing down Chrome's user session restoration.
-        // However, the restriction should be lifted once the user explicitly
-        // tries to launch an ARC app.
-        VLOG(2) << "Prioritizing the instance";
-        chromeos::SessionManagerClient* session_manager_client =
-            chromeos::DBusThreadManager::Get()->GetSessionManagerClient();
-        session_manager_client->SetArcCpuRestriction(
-            login_manager::CONTAINER_CPU_RESTRICTION_FOREGROUND,
-            base::Bind(SetArcCpuRestrictionCallback));
-      }
+      // On some boards, ARC is booted with a restricted set of resources by
+      // default to avoid slowing down Chrome's user session restoration.
+      // However, the restriction should be lifted once the user explicitly
+      // tries to launch an ARC app.
+      VLOG(2) << "Prioritizing the instance";
+      chromeos::SessionManagerClient* session_manager_client =
+          chromeos::DBusThreadManager::Get()->GetSessionManagerClient();
+      session_manager_client->SetArcCpuRestriction(
+          login_manager::CONTAINER_CPU_RESTRICTION_FOREGROUND,
+          base::Bind(SetArcCpuRestrictionCallback));
     }
     prefs->SetLastLaunchTime(app_id, base::Time::Now());
     return true;
   }
-
   return (new LaunchAppWithoutSize(context, app_id, landscape_layout,
                                    event_flags))
       ->LaunchAndRelease();
 }
 
 void SetTaskActive(int task_id) {
   arc::mojom::AppInstance* app_instance = GET_APP_INSTANCE(SetTaskActive);
   if (!app_instance)
     return;
   app_instance->SetTaskActive(task_id);
@@ skipping 112 matching lines @@
     return false;
 
   const ArcAppListPrefs* const arc_prefs = ArcAppListPrefs::Get(context);
   if (!arc_prefs)
     return false;
 
   return arc_prefs->IsRegistered(ArcAppShelfId::FromString(id).app_id());
 }
 
 }  // namespace arc