Start ARC and sign in after Chrome OS login

chrome/browser/chromeos/arc/arc_session_manager.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/arc/arc_session_manager.h"
 
 #include <utility>
 
 #include "ash/common/shelf/shelf_delegate.h"
 #include "ash/common/wm_shell.h"
@@ skipping 478 matching lines @@
       base::Bind(&ArcSessionManager::OnOptInPreferenceChanged,
                  weak_ptr_factory_.GetWeakPtr()));
 
   // Set initial managed state to ArcSupportHost to update the message.
   if (support_host_) {
     support_host_->SetArcManaged(
         IsArcPlayStoreEnabledPreferenceManagedForProfile(profile_));
   }
 
   // Update the state based on the initial Google Play Store enabled value.
-  if (IsArcPlayStoreEnabledForProfile(profile_)) {
+  if (ShouldArcAlwaysStart() || IsArcPlayStoreEnabledForProfile(profile_)) {
     VLOG(1) << "ARC is already enabled.";
     DCHECK(!enable_requested_);
     RequestEnable();
   } else {
     if (IsArcPlayStoreEnabledPreferenceManagedForProfile(profile_)) {
       // All users that can disable ARC by themselves will have the
       // |kARcDataRemoveRequested| pref set, so we don't need to eagerly remove
       // the data for that case.
       // For managed users, the preference can change when the Profile object is
       // not alive, so we still need to check it here in case it was disabled to
@@ skipping 33 matching lines @@
   }
 
   if (support_host_)
     support_host_->SetArcManaged(is_play_store_managed);
 
   // Hide auth notification if it was opened before and arc.enabled pref was
   // explicitly set to true or false.
   if (profile_->GetPrefs()->HasPrefPath(prefs::kArcEnabled))
     ArcAuthNotification::Hide();
 
-  if (is_play_store_enabled)
-    RequestEnable();
-  else
-    RequestDisable();
+  if (ShouldArcAlwaysStart()) {
+    // TODO(victorhsieh): Implement opt-in and opt-out flow.  For now, do
+    // nothing but keep the existing ARC instance running.

[Luis Héctor Chávez, 2017/03/01 22:25:38]

nit: return; to avoid the else.

[victorhsieh, 2017/03/02 00:28:12]

L563-564 should still run.

+  } else {
+    if (is_play_store_enabled)
+      RequestEnable();
+    else
+      RequestDisable();
+  }
 
   for (auto& observer : observer_list_)
     observer.OnArcPlayStoreEnabledChanged(is_play_store_enabled);
 }
 
 void ArcSessionManager::ShutdownSession() {
   arc_sign_in_timer_.Stop();
   playstore_launcher_.reset();
   terms_of_service_negotiator_.reset();
   android_management_checker_.reset();
@@ skipping 138 matching lines @@
   // TODO(poromov): Move to more Kiosk dedicated set-up phase.
   if (IsArcKioskMode())
     prefs->SetBoolean(prefs::kArcTermsAccepted, true);
 
   // Skip to show UI asking users to set up ARC OptIn preferences, if all of
   // them are managed by the admin policy. Note that the ToS agreement is anyway
   // not shown in the case of the managed ARC.
   if (AreArcAllOptInPreferencesManaged())
     prefs->SetBoolean(prefs::kArcTermsAccepted, true);
 
   // If it is marked that sign in has been successfully done, then directly

[Luis Héctor Chávez, 2017/03/01 22:25:38]

nit: "successfully done or if ARC has been set up to always start"

[victorhsieh, 2017/03/02 00:28:12]

Done.

   // start ARC.
   // For testing, and for Kiosk mode, we also skip ToS negotiation procedure.
   // For backward compatibility, this check needs to be prior to the
   // kArcTermsAccepted check below.
-  if (prefs->GetBoolean(prefs::kArcSignedIn) ||
+  if (prefs->GetBoolean(prefs::kArcSignedIn) || ShouldArcAlwaysStart() ||
       IsArcOptInVerificationDisabled() || IsArcKioskMode()) {
     StartArc();
 
     // Skip Android management check for testing.
     // We also skip if Android management check for Kiosk mode,
     // because there are no managed human users for Kiosk exist.
     if (IsArcOptInVerificationDisabled() || IsArcKioskMode() ||
         (g_disable_ui_for_testing &&
          !g_enable_check_android_management_for_testing)) {
       return;
@@ skipping 269 matching lines @@
 
 #undef MAP_STATE
 
   // Some compilers report an error even if all values of an enum-class are
   // covered exhaustively in a switch statement.
   NOTREACHED() << "Invalid value " << static_cast<int>(state);
   return os;
 }
 
 }  // namespace arc