Start ARC and sign in after Chrome OS login

chrome/browser/ui/app_list/arc/arc_app_utils.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/app_list/arc/arc_app_utils.h"
 
 #include <memory>
 #include <string>
 
 #include "ash/shell.h"
@@ skipping 251 matching lines @@
                const std::string& app_id,
                bool landscape_layout,
                int event_flags) {
   ArcAppListPrefs* prefs = ArcAppListPrefs::Get(context);
   std::unique_ptr<ArcAppListPrefs::AppInfo> app_info = prefs->GetApp(app_id);
   if (app_info && !app_info->ready) {
     ArcSessionManager* arc_session_manager = ArcSessionManager::Get();
     DCHECK(arc_session_manager);
 
     bool arc_activated = false;
-    if (!arc_session_manager->IsArcPlayStoreEnabled()) {
+    if (arc_session_manager->IsPersistentArc()) {

[hidehiko, 2017/02/23 10:29:16]

If Play Store is not yet enabled, I think it is still needed to enable it even
under PARC, otherwise apps on Play Store cannot be launched.
That means, apps need to be categorized into two groups, ones can run with PARC,
and ones need Play Store. Am I correct? If so any comments and/or plans?

[hidehiko, 2017/02/23 10:29:16]

nit: Could you elide the brace?

[victorhsieh, 2017/02/24 00:45:00]

Right.  There won't be apps from Play Store in opt-out mode, but default apps
like the note taking one is the exception that conceptually linked to Play
Store.  Clicking on them should launch the opt-in flow just like the opt out
case today.  This should be already the case and pARC shouldn't change that from
user's perspective.

Consider the use cases (line number based on the original copy):
1) launching app in the system image (L267 false -> L313)
2) launching default apps that needs to be installed from Play Store (L267 true
-> L272 -> L278 -> L294)

Now it seems to me that there is no difference between pARC and today here.  I'm
removing my change here, but please let me know if I missed something.

[victorhsieh, 2017/02/25 00:21:33]

Seems like there is an unlikely edge case when apps are registered, but the
instance is not ready.  Modify to bypass the NOTREACHED for pARC.

+      arc_activated = true;
+    }
+
+    if (!arc_activated && !arc_session_manager->IsArcPlayStoreEnabled()) {
       if (!prefs->IsDefault(app_id)) {
         NOTREACHED();
         return false;
       }
 
       arc_session_manager->SetArcPlayStoreEnabled(true);
       if (!arc_session_manager->IsArcPlayStoreEnabled()) {
         NOTREACHED();
         return false;
       }
@@ skipping 152 matching lines @@
     return false;
 
   const ArcAppListPrefs* const arc_prefs = ArcAppListPrefs::Get(context);
   if (!arc_prefs)
     return false;
 
   return arc_prefs->IsRegistered(ArcAppShelfId::FromString(id).app_id());
 }
 
 }  // namespace arc