Chromium Code Reviews| Index: chrome/test/data/webui/extensions/extension_item_test.js |
| diff --git a/chrome/test/data/webui/extensions/extension_item_test.js b/chrome/test/data/webui/extensions/extension_item_test.js |
| index 1abfcc33252191de96267d8ee38deea4aa21a078..dc5ef87dd451ade945ca4a5a511846883bf10e69 100644 |
| --- a/chrome/test/data/webui/extensions/extension_item_test.js |
| +++ b/chrome/test/data/webui/extensions/extension_item_test.js |
| @@ -25,9 +25,9 @@ cr.define('extension_item_tests', function() { |
| {selector: '#version', text: extensionData.version}, |
| {selector: '#extension-id', text: 'ID:' + extensionData.id}, |
| {selector: '#inspect-views'}, |
| - {selector: '#inspect-views paper-button', text: 'foo.html'}, |
| + {selector: '#inspect-views paper-button', text: 'foo.html,'}, |
| {selector: '#inspect-views paper-button:nth-of-type(0n + 2)', |
| - text: 'bar.html'}, |
| + text: '1 moreā¦'}, |
|
michaelpg
2017/02/23 04:22:08
why the fancy ellipsis?
Devlin
2017/02/23 19:09:21
That's apparently how we format the string in the
michaelpg
2017/02/27 01:29:50
Cool, TIL.
|
| ]; |
| /** |
| @@ -125,20 +125,29 @@ cr.define('extension_item_tests', function() { |
| mockDelegate.testClickingCalls( |
| item.$$('#inspect-views paper-button'), |
| 'inspectItemView', [item.data.id, item.data.views[0]]); |
| - mockDelegate.testClickingCalls( |
| - item.$$('#inspect-views paper-button:nth-of-type(0n + 2)'), |
| - 'inspectItemView', [item.data.id, item.data.views[1]]); |
| - var listener = new extension_test_util.ListenerMock(); |
| - listener.addListener(item, 'extension-item-show-details', |
| + var listener1 = new extension_test_util.ListenerMock(); |
| + listener1.addListener(item, 'extension-item-show-details', |
| {data: item.data}); |
| MockInteractions.tap(item.$$('#details-button')); |
| - listener.verify(); |
| + listener1.verify(); |
| + |
| + var listener2 = new extension_test_util.ListenerMock(); |
| + listener2.addListener(item, 'extension-item-show-details', |
| + {data: item.data}); |
| + MockInteractions.tap( |
| + item.$$('#inspect-views paper-button:nth-of-type(0n + 2)')); |
|
michaelpg
2017/02/23 04:22:08
you don't need the 0n +
https://drafts.csswg.org/s
Devlin
2017/02/23 19:09:21
Done.
michaelpg
2017/02/27 01:29:50
well, you did the one above instead ;-)
|
| + listener2.verify(); |
| item.set('data.disableReasons.corruptInstall', true); |
| Polymer.dom.flush(); |
| mockDelegate.testClickingCalls( |
| item.$$('#repair-button'), 'repairItem', [item.data.id]); |
| + |
| + item.set('data.disableReasons.corruptInstall', false); |
| + Polymer.dom.flush(); |
| + mockDelegate.testClickingCalls( |
| + item.$$('#reload-button'), 'reloadItem', [item.data.id]); |
| }); |
| test(assert(TestNames.Warnings), function() { |