Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Side by Side Diff: chrome/browser/ui/webui/extensions/extensions_ui.cc

Issue 2707083003: [MD Extensions] Update Item Card UI (Closed)
Patch Set: missed one Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/extensions/extensions_ui.h" 5 #include "chrome/browser/ui/webui/extensions/extensions_ui.h"
6 6
7 #include <memory> 7 #include <memory>
8 8
9 #include "base/memory/ptr_util.h" 9 #include "base/memory/ptr_util.h"
10 #include "base/metrics/histogram_macros.h" 10 #include "base/metrics/histogram_macros.h"
(...skipping 113 matching lines...) Expand 10 before | Expand all | Expand 10 after
124 IDS_EXTENSIONS_INSTALL_DROP_TARGET); 124 IDS_EXTENSIONS_INSTALL_DROP_TARGET);
125 source->AddLocalizedString("errorsPageHeading", 125 source->AddLocalizedString("errorsPageHeading",
126 IDS_MD_EXTENSIONS_ERROR_PAGE_HEADING); 126 IDS_MD_EXTENSIONS_ERROR_PAGE_HEADING);
127 source->AddLocalizedString("getMoreExtensions", 127 source->AddLocalizedString("getMoreExtensions",
128 IDS_MD_EXTENSIONS_SIDEBAR_GET_MORE_EXTENSIONS); 128 IDS_MD_EXTENSIONS_SIDEBAR_GET_MORE_EXTENSIONS);
129 source->AddLocalizedString("keyboardShortcuts", 129 source->AddLocalizedString("keyboardShortcuts",
130 IDS_MD_EXTENSIONS_SIDEBAR_KEYBOARD_SHORTCUTS); 130 IDS_MD_EXTENSIONS_SIDEBAR_KEYBOARD_SHORTCUTS);
131 source->AddLocalizedString("itemId", IDS_MD_EXTENSIONS_ITEM_ID); 131 source->AddLocalizedString("itemId", IDS_MD_EXTENSIONS_ITEM_ID);
132 source->AddLocalizedString("itemInspectViews", 132 source->AddLocalizedString("itemInspectViews",
133 IDS_MD_EXTENSIONS_ITEM_INSPECT_VIEWS); 133 IDS_MD_EXTENSIONS_ITEM_INSPECT_VIEWS);
134 // NOTE: This text reads "<n> more". It's possible that it should be using
135 // a plural string instead. Unfortunately, this is non-trivial since we don't
136 // expose that capability to JS yet. Since we don't know it's a problem, use
137 // a simple placeholder for now.
138 source->AddLocalizedString("itemInspectViewsExtra",
139 IDS_MD_EXTENSIONS_ITEM_INSPECT_VIEWS_EXTRA);
134 source->AddLocalizedString("itemAllowIncognito", 140 source->AddLocalizedString("itemAllowIncognito",
135 IDS_MD_EXTENSIONS_ITEM_ALLOW_INCOGNITO); 141 IDS_MD_EXTENSIONS_ITEM_ALLOW_INCOGNITO);
136 source->AddLocalizedString("itemDescriptionLabel", 142 source->AddLocalizedString("itemDescriptionLabel",
137 IDS_MD_EXTENSIONS_ITEM_DESCRIPTION); 143 IDS_MD_EXTENSIONS_ITEM_DESCRIPTION);
138 source->AddLocalizedString("itemDependencies", 144 source->AddLocalizedString("itemDependencies",
139 IDS_MD_EXTENSIONS_ITEM_DEPENDENCIES); 145 IDS_MD_EXTENSIONS_ITEM_DEPENDENCIES);
140 source->AddLocalizedString("itemDependentEntry", 146 source->AddLocalizedString("itemDependentEntry",
141 IDS_MD_EXTENSIONS_DEPENDENT_ENTRY); 147 IDS_MD_EXTENSIONS_DEPENDENT_ENTRY);
142 source->AddLocalizedString("itemDetails", IDS_MD_EXTENSIONS_ITEM_DETAILS); 148 source->AddLocalizedString("itemDetails", IDS_MD_EXTENSIONS_ITEM_DETAILS);
143 source->AddLocalizedString("itemErrors", IDS_MD_EXTENSIONS_ITEM_ERRORS); 149 source->AddLocalizedString("itemErrors", IDS_MD_EXTENSIONS_ITEM_ERRORS);
(...skipping 16 matching lines...) Expand all
160 IDS_MD_EXTENSIONS_ITEM_VERSION); 166 IDS_MD_EXTENSIONS_ITEM_VERSION);
161 source->AddLocalizedString("itemAllowOnFileUrls", 167 source->AddLocalizedString("itemAllowOnFileUrls",
162 IDS_EXTENSIONS_ALLOW_FILE_ACCESS); 168 IDS_EXTENSIONS_ALLOW_FILE_ACCESS);
163 source->AddLocalizedString("itemAllowOnAllSites", 169 source->AddLocalizedString("itemAllowOnAllSites",
164 IDS_EXTENSIONS_ALLOW_ON_ALL_URLS); 170 IDS_EXTENSIONS_ALLOW_ON_ALL_URLS);
165 source->AddLocalizedString("itemCollectErrors", 171 source->AddLocalizedString("itemCollectErrors",
166 IDS_EXTENSIONS_ENABLE_ERROR_COLLECTION); 172 IDS_EXTENSIONS_ENABLE_ERROR_COLLECTION);
167 source->AddLocalizedString("itemCorruptInstall", 173 source->AddLocalizedString("itemCorruptInstall",
168 IDS_EXTENSIONS_CORRUPTED_EXTENSION); 174 IDS_EXTENSIONS_CORRUPTED_EXTENSION);
169 source->AddLocalizedString("itemRepair", IDS_EXTENSIONS_REPAIR_CORRUPTED); 175 source->AddLocalizedString("itemRepair", IDS_EXTENSIONS_REPAIR_CORRUPTED);
176 source->AddLocalizedString("itemReload", IDS_EXTENSIONS_RELOAD_TERMINATED);
170 source->AddString( 177 source->AddString(
171 "itemSuspiciousInstall", 178 "itemSuspiciousInstall",
172 l10n_util::GetStringFUTF16( 179 l10n_util::GetStringFUTF16(
173 IDS_EXTENSIONS_ADDED_WITHOUT_KNOWLEDGE, 180 IDS_EXTENSIONS_ADDED_WITHOUT_KNOWLEDGE,
174 l10n_util::GetStringUTF16(IDS_EXTENSION_WEB_STORE_TITLE))); 181 l10n_util::GetStringUTF16(IDS_EXTENSION_WEB_STORE_TITLE)));
175 source->AddLocalizedString("noErrorsToShow", 182 source->AddLocalizedString("noErrorsToShow",
176 IDS_EXTENSIONS_ERROR_NO_ERRORS_CODE_MESSAGE); 183 IDS_EXTENSIONS_ERROR_NO_ERRORS_CODE_MESSAGE);
177 source->AddLocalizedString("packDialogTitle", 184 source->AddLocalizedString("packDialogTitle",
178 IDS_MD_EXTENSIONS_PACK_DIALOG_TITLE); 185 IDS_MD_EXTENSIONS_PACK_DIALOG_TITLE);
179 source->AddLocalizedString("packDialogBrowse", 186 source->AddLocalizedString("packDialogBrowse",
(...skipping 168 matching lines...) Expand 10 before | Expand all | Expand 10 after
348 ExtensionsUI::~ExtensionsUI() {} 355 ExtensionsUI::~ExtensionsUI() {}
349 356
350 // static 357 // static
351 base::RefCountedMemory* ExtensionsUI::GetFaviconResourceBytes( 358 base::RefCountedMemory* ExtensionsUI::GetFaviconResourceBytes(
352 ui::ScaleFactor scale_factor) { 359 ui::ScaleFactor scale_factor) {
353 ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance(); 360 ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance();
354 return rb.LoadDataResourceBytesForScale(IDR_EXTENSIONS_FAVICON, scale_factor); 361 return rb.LoadDataResourceBytesForScale(IDR_EXTENSIONS_FAVICON, scale_factor);
355 } 362 }
356 363
357 } // namespace extensions 364 } // namespace extensions
OLDNEW
« no previous file with comments | « chrome/browser/resources/md_extensions/service.js ('k') | chrome/test/data/webui/extensions/extension_item_test.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698