Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutBox.cpp

Issue 2707073002: Move PreviousBoxGeometries from BoxPaintInvalidator into LayoutBox::m_rareData (Closed)
Patch Set: uninline savePreviousOtherBoxGeometries() Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com) 4 * (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com)
5 * (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com) 5 * (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com)
6 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. 6 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc.
7 * All rights reserved. 7 * All rights reserved.
8 * Copyright (C) 2013 Adobe Systems Incorporated. All rights reserved. 8 * Copyright (C) 2013 Adobe Systems Incorporated. All rights reserved.
9 * 9 *
10 * This library is free software; you can redistribute it and/or 10 * This library is free software; you can redistribute it and/or
(...skipping 116 matching lines...) Expand 10 before | Expand all | Expand 10 after
127 clearExtraInlineAndBlockOffests(); 127 clearExtraInlineAndBlockOffests();
128 128
129 if (isOutOfFlowPositioned()) 129 if (isOutOfFlowPositioned())
130 LayoutBlock::removePositionedObject(this); 130 LayoutBlock::removePositionedObject(this);
131 removeFromPercentHeightContainer(); 131 removeFromPercentHeightContainer();
132 if (isOrthogonalWritingModeRoot() && !documentBeingDestroyed()) 132 if (isOrthogonalWritingModeRoot() && !documentBeingDestroyed())
133 unmarkOrthogonalWritingModeRoot(); 133 unmarkOrthogonalWritingModeRoot();
134 134
135 ShapeOutsideInfo::removeInfo(*this); 135 ShapeOutsideInfo::removeInfo(*this);
136 136
137 BoxPaintInvalidator::boxWillBeDestroyed(*this);
138
139 LayoutBoxModelObject::willBeDestroyed(); 137 LayoutBoxModelObject::willBeDestroyed();
140 } 138 }
141 139
142 void LayoutBox::insertedIntoTree() { 140 void LayoutBox::insertedIntoTree() {
143 LayoutBoxModelObject::insertedIntoTree(); 141 LayoutBoxModelObject::insertedIntoTree();
144 addScrollSnapMapping(); 142 addScrollSnapMapping();
145 143
146 if (isOrthogonalWritingModeRoot()) 144 if (isOrthogonalWritingModeRoot())
147 markOrthogonalWritingModeRoot(); 145 markOrthogonalWritingModeRoot();
148 } 146 }
(...skipping 5565 matching lines...) Expand 10 before | Expand all | Expand 10 after
5714 if (block) 5712 if (block)
5715 block->adjustChildDebugRect(rect); 5713 block->adjustChildDebugRect(rect);
5716 5714
5717 return rect; 5715 return rect;
5718 } 5716 }
5719 5717
5720 bool LayoutBox::shouldClipOverflow() const { 5718 bool LayoutBox::shouldClipOverflow() const {
5721 return hasOverflowClip() || styleRef().containsPaint() || hasControlClip(); 5719 return hasOverflowClip() || styleRef().containsPaint() || hasControlClip();
5722 } 5720 }
5723 5721
5722 void LayoutBox::savePreviousOtherBoxGeometries() {
5723 auto& rareData = ensureRareData();
5724 rareData.m_hasPreviousOtherBoxGeometries = true;
5725 rareData.m_previousContentBoxSize = contentBoxRect().size();
5726 rareData.m_previousLayoutOverflowRect = layoutOverflowRect();
5727 }
5728
5724 } // namespace blink 5729 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698