Universial component install for chrome os.

chrome/browser/component_updater/cros_component_installer_unittest.cc

Index: chrome/browser/component_updater/cros_component_installer_unittest.cc
diff --git a/chrome/browser/component_updater/cros_component_installer_unittest.cc b/chrome/browser/component_updater/cros_component_installer_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..2af45e7104dea64783480178dd291fb5a559b319
--- /dev/null
+++ b/chrome/browser/component_updater/cros_component_installer_unittest.cc
@@ -0,0 +1,62 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/component_updater/cros_component_installer.h"
+#include "base/run_loop.h"
+#include "base/test/test_simple_task_runner.h"
+#include "base/threading/thread_task_runner_handle.h"
+#include "chrome/test/base/testing_browser_process.h"
+#include "components/component_updater/mock_component_updater_service.h"
+#include "content/public/test/test_browser_thread_bundle.h"
+#include "testing/gtest/include/gtest/gtest.h"
+#include "testing/platform_test.h"
+
+#if defined(OS_CHROMEOS)
+#include "build/build_config.h"
+#endif  // defined(OS_CHROMEOS)
+
+namespace component_updater {
+
+class CrOSMockComponentUpdateService
+    : public component_updater::MockComponentUpdateService {
+ public:
+  CrOSMockComponentUpdateService() {}
+  ~CrOSMockComponentUpdateService() override {}
+
+  scoped_refptr<base::SequencedTaskRunner> GetSequencedTaskRunner() override {
+    return base::ThreadTaskRunnerHandle::Get();
+  }
+
+ private:
+  content::TestBrowserThreadBundle thread_bundle_;
+  DISALLOW_COPY_AND_ASSIGN(CrOSMockComponentUpdateService);
+};
+
+class CrOSComponentInstallerTest : public PlatformTest {
+ public:
+  CrOSComponentInstallerTest() {}
+
+  void SetUp() override { PlatformTest::SetUp(); }
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(CrOSComponentInstallerTest);
+};
+
+#if defined(OS_CHROMEOS)
+TEST_F(CrOSComponentInstallerTest, RegisterESCPR) {
+  std::unique_ptr<CrOSMockComponentUpdateService> cus(
+      new CrOSMockComponentUpdateService());

[Sorin Jianu, 2017/03/03 02:19:03]

can use base::MakeUnique<CrOSMockComponentUpdateService>()

In general, direct calls to the new operator are looked upon with increased
scrutiny and they are better avoided.

[xiaochu, 2017/03/03 17:16:25]

Done.

+  EXPECT_CALL(*cus, RegisterComponent(testing::_)).Times(1);
+  component_updater::RegisterCrOSComponent(cus.get(), "escpr");
+  base::RunLoop().RunUntilIdle();
+}
+TEST_F(CrOSComponentInstallerTest, RegisterFakeComponent) {
+  std::unique_ptr<CrOSMockComponentUpdateService> cus(
+      new CrOSMockComponentUpdateService());

[Sorin Jianu, 2017/03/03 02:19:03]

same

[xiaochu, 2017/03/03 17:16:25]

Done.

+  EXPECT_CALL(*cus, RegisterComponent(testing::_)).Times(0);
+  RegisterCrOSComponent(cus.get(), "arandomname");
+  base::RunLoop().RunUntilIdle();
+}
+#endif  // defined(OS_CHROMEOS)
+}  // namespace component_updater

[Sorin Jianu, 2017/03/03 02:19:03]

an empty line above would help

[xiaochu, 2017/03/03 17:16:25]

Done.