Universial component install for chrome os.

chrome/browser/component_updater/cros_component_installer.h

Index: chrome/browser/component_updater/cros_component_installer.h
diff --git a/chrome/browser/component_updater/cros_component_installer.h b/chrome/browser/component_updater/cros_component_installer.h
new file mode 100644
index 0000000000000000000000000000000000000000..f900b9f090f642762d553aa08146971f49a82be8
--- /dev/null
+++ b/chrome/browser/component_updater/cros_component_installer.h
@@ -0,0 +1,69 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.

[Sorin Jianu, 2017/03/03 02:19:03]

Needs an empty line after this.

[xiaochu, 2017/03/03 17:16:25]

Done.

+#ifndef CHROME_BROWSER_COMPONENT_UPDATER_CROS_COMPONENT_INSTALLER_H_
+#define CHROME_BROWSER_COMPONENT_UPDATER_CROS_COMPONENT_INSTALLER_H_
+
+#include <string>
+
+#include "components/component_updater/default_component_installer.h"
+#include "crypto/sha2.h"
+
+#if defined(OS_CHROMEOS)
+#include "build/build_config.h"

[Sorin Jianu, 2017/03/03 02:19:03]

This can and must be included outside the #if directives since it is the header
that defines some of these platform symbols.

[xiaochu, 2017/03/03 17:16:25]

Done.

+#endif  // defined(OS_CHROMEOS)
+
+namespace component_updater {
+
+class ComponentUpdateService;
+
+struct ComponentConfig {
+  std::string name;
+  std::string dir;
+  std::string sha2hashstr;
+  ComponentConfig(const std::string& name,
+                  const std::string& dir,
+                  const std::string& sha2hashstr)
+      : name(name), dir(dir), sha2hashstr(sha2hashstr) {}

[Sorin Jianu, 2017/03/03 02:19:03]

we want to define the ctor and dtor in a cc file, otherwise they will still be
inline.
The issue here is that an inline ctor results into calling 3 constructors for
the string members and may bloat the code size.

[xiaochu, 2017/03/03 17:16:25]

Done.

+  ~ComponentConfig() {}
+};
+#if defined(OS_CHROMEOS)

[Sorin Jianu, 2017/03/03 02:19:03]

an empty line between 29 and 30  would be helpful for readability.

[xiaochu, 2017/03/03 17:16:25]

Done.

+class CrOSComponentInstallerTraits : public ComponentInstallerTraits {
+ public:
+  explicit CrOSComponentInstallerTraits(const ComponentConfig& config);
+  ~CrOSComponentInstallerTraits() override {}
+
+ private:
+  // The following methods override ComponentInstallerTraits.
+  bool SupportsGroupPolicyEnabledComponentUpdates() const override;
+  bool RequiresNetworkEncryption() const override;
+  update_client::CrxInstaller::Result OnCustomInstall(
+      const base::DictionaryValue& manifest,
+      const base::FilePath& install_dir) override;
+  bool VerifyInstallation(const base::DictionaryValue& manifest,
+                          const base::FilePath& install_dir) const override;
+  void ComponentReady(const base::Version& version,
+                      const base::FilePath& path,
+                      std::unique_ptr<base::DictionaryValue> manifest) override;
+  base::FilePath GetRelativeInstallDir() const override;
+  void GetHash(std::vector<uint8_t>* hash) const override;
+  std::string GetName() const override;
+  update_client::InstallerAttributes GetInstallerAttributes() const override;
+  std::vector<std::string> GetMimeTypes() const override;
+  std::string dir_name;
+  std::string name;
+  uint8_t kSha2Hash_[crypto::kSHA256Length] = {};
+
+  DISALLOW_COPY_AND_ASSIGN(CrOSComponentInstallerTraits);
+};
+
+#endif  // defined(OS_CHROMEOS)
+
+// Register a CrOS component.
+// It must be called on UI thread.
+bool RegisterCrOSComponent(ComponentUpdateService* cus,
+                           const std::string& name);
+
+}  // namespace component_updater
+
+#endif  // CHROME_BROWSER_COMPONENT_UPDATER_CROS_COMPONENT_INSTALLER_H_