Universial component install for chrome os.

chrome/browser/component_updater/cros_component_installer.h

Index: chrome/browser/component_updater/cros_component_installer.h
diff --git a/chrome/browser/component_updater/cros_component_installer.h b/chrome/browser/component_updater/cros_component_installer.h
new file mode 100644
index 0000000000000000000000000000000000000000..83ab10bf734e5693bba2c357a18c810c851d6966
--- /dev/null
+++ b/chrome/browser/component_updater/cros_component_installer.h
@@ -0,0 +1,60 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+#ifndef CHROME_BROWSER_COMPONENT_UPDATER_CROS_COMPONENT_INSTALLER_H_
+#define CHROME_BROWSER_COMPONENT_UPDATER_CROS_COMPONENT_INSTALLER_H_
+
+#include "components/component_updater/default_component_installer.h"
+#include "crypto/sha2.h"
+
+namespace component_updater {
+
+class ComponentUpdateService;
+
+struct ComponentConfig {

[Sorin Jianu, 2017/03/02 22:27:25]

Also, we usually declare ctor and dtor for such data types, otherwise they get
inlined and bloat the code size.

[xiaochu, 2017/03/03 00:08:53]

Done.

+  std::string name;

[Sorin Jianu, 2017/03/02 22:27:25]

include <string>

[xiaochu, 2017/03/03 00:08:53]

Done.

+  std::string dir;
+  std::string sha2hashstr;
+};
+#if defined(OS_CHROMEOS)

[Sorin Jianu, 2017/03/02 22:27:25]

Superimportant: #include "build/build_config.h"
when platform depended compile time definitions are used.

[xiaochu, 2017/03/03 00:08:53]

included once here. not including it in .cc file. is that fine?

+class CrOSComponentInstallerTraits : public ComponentInstallerTraits {
+ public:
+  CrOSComponentInstallerTraits(std::string dir_name,

[Sorin Jianu, 2017/03/02 22:27:25]

& to const type

[Sorin Jianu, 2017/03/02 22:27:25]

Can it take a ComponentConfig as a param?

[xiaochu, 2017/03/03 00:08:53]

Done.

+                               std::string name,
+                               std::string sha2HashStr);
+  ~CrOSComponentInstallerTraits() override {}
+
+ private:
+  // The following methods override ComponentInstallerTraits.
+  bool SupportsGroupPolicyEnabledComponentUpdates() const override;
+  bool RequiresNetworkEncryption() const override;
+  update_client::CrxInstaller::Result OnCustomInstall(
+      const base::DictionaryValue& manifest,
+      const base::FilePath& install_dir) override;
+  bool VerifyInstallation(const base::DictionaryValue& manifest,
+                          const base::FilePath& install_dir) const override;
+  void ComponentReady(const base::Version& version,
+                      const base::FilePath& path,
+                      std::unique_ptr<base::DictionaryValue> manifest) override;
+  base::FilePath GetRelativeInstallDir() const override;
+  void GetHash(std::vector<uint8_t>* hash) const override;
+  std::string GetName() const override;
+  update_client::InstallerAttributes GetInstallerAttributes() const override;
+  std::vector<std::string> GetMimeTypes() const override;
+  std::string dir_name;
+  std::string name;
+  uint8_t kSha2Hash_[crypto::kSHA256Length] = {};
+
+  DISALLOW_COPY_AND_ASSIGN(CrOSComponentInstallerTraits);
+};
+
+#endif  // defined(OS_CHROMEOS)
+
+// Register a CrOS component.
+// It must be called on UI thread.
+bool RegisterCrOSComponent(ComponentUpdateService* cus,
+                           const std::string& name);
+
+}  // namespace component_updater
+
+#endif  // CHROME_BROWSER_COMPONENT_UPDATER_CROS_COMPONENT_INSTALLER_H_