Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1081)

Unified Diff: cc/scheduler/scheduler.cc

Issue 270703004: Making BeginFrameArgs work with TRACE_EVENT system. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« cc/output/begin_frame_args.h ('K') | « cc/output/begin_frame_args.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/scheduler/scheduler.cc
diff --git a/cc/scheduler/scheduler.cc b/cc/scheduler/scheduler.cc
index 88c8c74f701d2f4aa0a8980cff8b01f2a21335ea..caed7f4ca763e814d80028448b70b3961eb1196e 100644
--- a/cc/scheduler/scheduler.cc
+++ b/cc/scheduler/scheduler.cc
@@ -394,7 +394,8 @@ void Scheduler::SetupPollingMechanisms(bool needs_begin_frame) {
// If the scheduler is busy, we queue the BeginFrame to be handled later as
// a BeginRetroFrame.
void Scheduler::BeginFrame(const BeginFrameArgs& args) {
- TRACE_EVENT1("cc", "Scheduler::BeginFrame", "frame_time", args.frame_time);
+ TRACE_EVENT1("cc", "Scheduler::BeginFrame", "args", args.AsTrace());
+ // scoped_refptr<base::debug::ConvertableToTraceFormat>(args));
DCHECK(settings_.throttle_frame_production);
bool should_defer_begin_frame;
@@ -488,8 +489,7 @@ void Scheduler::PostBeginRetroFrameIfNeeded() {
// for a BeginMainFrame+activation to complete before it times out and draws
// any asynchronous animation and scroll/pinch updates.
void Scheduler::BeginImplFrame(const BeginFrameArgs& args) {
- TRACE_EVENT1(
- "cc", "Scheduler::BeginImplFrame", "frame_time", args.frame_time);
+ TRACE_EVENT1("cc", "Scheduler::BeginImplFrame", "args", args.AsTrace());
DCHECK(state_machine_.begin_impl_frame_state() ==
SchedulerStateMachine::BEGIN_IMPL_FRAME_STATE_IDLE);
DCHECK(state_machine_.HasInitializedOutputSurface());
@@ -713,6 +713,9 @@ scoped_ptr<base::Value> Scheduler::StateAsValue() const {
!poll_for_draw_triggers_task_.IsCancelled());
scheduler_state->SetBoolean("advance_commit_state_task_",
!advance_commit_state_task_.IsCancelled());
+ scheduler_state->Set("begin_impl_frame_args",
+ begin_impl_frame_args_.AsValue().release());
+
state->Set("scheduler_state", scheduler_state.release());
scoped_ptr<base::DictionaryValue> client_state(new base::DictionaryValue);
« cc/output/begin_frame_args.h ('K') | « cc/output/begin_frame_args.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698