Making BeginFrameArgs work with TRACE_EVENT system.

Making BeginFrameArgs work with TRACE_EVENT system.

 * Added ToValue() method on BeginFrameArgs.
 * Added a ToTrace method inside cc/traced_value.h for easy conversion, just do a ToTrace(XXX) of anything which has a ToValue() method.
 * Rename Scheduler::StateAsValue to AsValue so it works with above.

BUG=371223
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269487

[mithro-old, 2014-05-08 08:32:01]

Hi Brian,

This CL adds support for using the BeginFrameArgs inside TRACE_EVENT system.

Extracted from https://codereview.chromium.org/267783004/

Tim 'mithro' Ansell

[brianderson, 2014-05-08 17:03:16]

https://codereview.chromium.org/270703004/diff/1/cc/output/begin_frame_args.h
File cc/output/begin_frame_args.h (right):

https://codereview.chromium.org/270703004/diff/1/cc/output/begin_frame_args.h...
cc/output/begin_frame_args.h:45:
scoped_refptr<base::debug::ConvertableToTraceFormat> AsTrace() const;
How is AsTrace() different than AsValue()?

[mithro-old, 2014-05-08 19:44:23]

https://codereview.chromium.org/270703004/diff/1/cc/output/begin_frame_args.h
File cc/output/begin_frame_args.h (right):

https://codereview.chromium.org/270703004/diff/1/cc/output/begin_frame_args.h...
cc/output/begin_frame_args.h:45:
scoped_refptr<base::debug::ConvertableToTraceFormat> AsTrace() const;
On 2014/05/08 17:03:16, brianderson wrote:
> How is AsTrace() different than AsValue()?

AsTrace is used for giving to the trace system. 

AsValue is used for using BeginFrameArgs inside somewhere else's AsValue() (IE
The scheduler's).

[mithro-old, 2014-05-08 21:21:24]

PTAL.

Turns out that the TracedValue code was already found in cc/debug/traced_value.h

Went with the template idea to get rid of AsTrace method in begin_frame_args.

[brianderson, 2014-05-08 21:25:48]

https://codereview.chromium.org/270703004/diff/80001/cc/debug/traced_value.h
File cc/debug/traced_value.h (right):

https://codereview.chromium.org/270703004/diff/80001/cc/debug/traced_value.h#...
cc/debug/traced_value.h:50: static
scoped_refptr<base::debug::ConvertableToTraceFormat> ToTrace(T* t) {
Nice!

https://codereview.chromium.org/270703004/diff/80001/cc/output/begin_frame_ar...
File cc/output/begin_frame_args.h (right):

https://codereview.chromium.org/270703004/diff/80001/cc/output/begin_frame_ar...
cc/output/begin_frame_args.h:43: scoped_ptr<base::Value> StateAsValue() const;
Why not just AsValue()?

https://codereview.chromium.org/270703004/diff/80001/cc/scheduler/scheduler.cc
File cc/scheduler/scheduler.cc (right):

https://codereview.chromium.org/270703004/diff/80001/cc/scheduler/scheduler.c...
cc/scheduler/scheduler.cc:689: scoped_ptr<base::Value> Scheduler::StateAsValue()
const {
Feel free to rename this to AsValue() - I think AsValue is the more common name.

[mithro-old, 2014-05-08 21:36:24]

On 2014/05/08 21:25:48, brianderson wrote:
> https://codereview.chromium.org/270703004/diff/80001/cc/debug/traced_value.h
> File cc/debug/traced_value.h (right):
> 
>
https://codereview.chromium.org/270703004/diff/80001/cc/debug/traced_value.h#...
> cc/debug/traced_value.h:50: static
> scoped_refptr<base::debug::ConvertableToTraceFormat> ToTrace(T* t) {
> Nice!
> 
>
https://codereview.chromium.org/270703004/diff/80001/cc/output/begin_frame_ar...
> File cc/output/begin_frame_args.h (right):
> 
>
https://codereview.chromium.org/270703004/diff/80001/cc/output/begin_frame_ar...
> cc/output/begin_frame_args.h:43: scoped_ptr<base::Value> StateAsValue() const;
> Why not just AsValue()?
> 
> https://codereview.chromium.org/270703004/diff/80001/cc/scheduler/scheduler.cc
> File cc/scheduler/scheduler.cc (right):
> 
>
https://codereview.chromium.org/270703004/diff/80001/cc/scheduler/scheduler.c...
> cc/scheduler/scheduler.cc:689: scoped_ptr<base::Value>
Scheduler::StateAsValue()
> const {
> Feel free to rename this to AsValue() - I think AsValue is the more common
name.

Done. All using "AsValue()" now.

[brianderson, 2014-05-08 21:43:24]

https://codereview.chromium.org/270703004/diff/100001/cc/debug/traced_value.h
File cc/debug/traced_value.h (right):

https://codereview.chromium.org/270703004/diff/100001/cc/debug/traced_value.h...
cc/debug/traced_value.h:50: static
scoped_refptr<base::debug::ConvertableToTraceFormat> ToTrace(T* t) {
lgtm if Nat's happy with this file.

[nduca, 2014-05-09 00:21:46]

lgtm

[mithro-old, 2014-05-09 00:48:43]

The CQ bit was checked by mithro@mithis.com

[commit-bot: I haz the power, 2014-05-09 00:50:11]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mithro@mithis.com/270703004/100001

[commit-bot: I haz the power, 2014-05-09 02:23:59]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-05-10 02:16:04]

Change committed as 269487