Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 270703003: Use ExtensionRegistryObserver instead of DEPRECATED extension notify from app_window_geometry_cache (Closed)

Created:
6 years, 7 months ago by limasdf
Modified:
6 years, 7 months ago
CC:
chromium-reviews, tfarina, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Use ExtensionRegistryObserver instead of DEPRECATED extension notify from app_window_geometry_cache BUG=354046 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269523

Patch Set 1 : #

Patch Set 2 : fix unit_tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -57 lines) Patch
M apps/app_window_geometry_cache.h View 4 chunks +20 lines, -12 lines 0 comments Download
M apps/app_window_geometry_cache.cc View 4 chunks +16 lines, -39 lines 0 comments Download
M apps/app_window_geometry_cache_unittest.cc View 1 3 chunks +26 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
limasdf
one day one fix-_-;; I hope this doens't bother you ptal
6 years, 7 months ago (2014-05-07 16:30:54 UTC) #1
not at google - send to devlin
lgtm these never bother me!
6 years, 7 months ago (2014-05-07 16:36:41 UTC) #2
limasdf
The CQ bit was checked by limasdf@gmail.com
6 years, 7 months ago (2014-05-07 16:41:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/limasdf@gmail.com/270703003/20001
6 years, 7 months ago (2014-05-07 16:42:48 UTC) #4
limasdf
The CQ bit was unchecked by limasdf@gmail.com
6 years, 7 months ago (2014-05-07 18:11:58 UTC) #5
limasdf
The CQ bit was checked by limasdf@gmail.com
6 years, 7 months ago (2014-05-09 04:03:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/limasdf@gmail.com/270703003/40001
6 years, 7 months ago (2014-05-09 04:06:15 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-09 06:07:55 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-09 06:41:59 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/builds/8648)
6 years, 7 months ago (2014-05-09 06:42:00 UTC) #10
limasdf
The CQ bit was checked by limasdf@gmail.com
6 years, 7 months ago (2014-05-09 07:00:54 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/limasdf@gmail.com/270703003/40001
6 years, 7 months ago (2014-05-09 07:09:01 UTC) #12
commit-bot: I haz the power
6 years, 7 months ago (2014-05-10 04:40:01 UTC) #13
Message was sent while issue was closed.
Change committed as 269523

Powered by Google App Engine
This is Rietveld 408576698