Train ddc snapshot on itself

Train ddc snapshot on itself

This speeds up dartdevc on hello world from about 600ms to about 150ms.

OTOH, it also increases the snapshot size from ~4.6M to ~31M (the
latter is just under the size of the dart2js snapshot).

R=jacobr@google.com

Committed: https://github.com/dart-lang/sdk/commit/e4733ac1457225b98c1b78f10b883ebad24fc81c

[vsm, 2017-02-21 14:41:11]

Description was changed from

==========
Train ddc snapshot on itself

This speeds up dartdevc on hello world from about 600ms to about 150ms.

OTOH, it also increases the snapshot size from ~4.6M to ~31M (the
latter is just under the size of the dart2js snapshot).
==========

to

==========
Train ddc snapshot on itself

This speeds up dartdevc on hello world from about 600ms to about 150ms.

OTOH, it also increases the snapshot size from ~4.6M to ~31M (the
latter is just under the size of the dart2js snapshot).
==========

[vsm, 2017-02-21 14:41:11]

vsm@google.com changed reviewers:
+ jacobr@google.com

[Jacob, 2017-02-21 15:28:52]

lgtm

https://codereview.chromium.org/2707023002/diff/1/utils/dartdevc/BUILD.gn
File utils/dartdevc/BUILD.gn (right):

https://codereview.chromium.org/2707023002/diff/1/utils/dartdevc/BUILD.gn#new...
utils/dartdevc/BUILD.gn:16: "--unsafe-force-compile",
random idea: can we train it on some large existing package more representative
of real world workloads instead of compiling ddc on itself?
that would allow removing the --unsafe-force-compile arguments and likely make
the training data more representative of real world workloads. For example,
train on the angular package?

[vsm, 2017-02-21 15:36:33]

On 2017/02/21 15:28:52, Jacob wrote:
> lgtm
> 
> https://codereview.chromium.org/2707023002/diff/1/utils/dartdevc/BUILD.gn
> File utils/dartdevc/BUILD.gn (right):
> 
>
https://codereview.chromium.org/2707023002/diff/1/utils/dartdevc/BUILD.gn#new...
> utils/dartdevc/BUILD.gn:16: "--unsafe-force-compile",
> random idea: can we train it on some large existing package more
representative
> of real world workloads instead of compiling ddc on itself?
> that would allow removing the --unsafe-force-compile arguments and likely make
> the training data more representative of real world workloads. For example,
> train on the angular package?

It could be anything in our current SDK checkout.  That doesn't include angular
right now though.

[vsm, 2017-02-21 23:56:25]

Description was changed from

==========
Train ddc snapshot on itself

This speeds up dartdevc on hello world from about 600ms to about 150ms.

OTOH, it also increases the snapshot size from ~4.6M to ~31M (the
latter is just under the size of the dart2js snapshot).
==========

to

==========
Train ddc snapshot on itself

This speeds up dartdevc on hello world from about 600ms to about 150ms.

OTOH, it also increases the snapshot size from ~4.6M to ~31M (the
latter is just under the size of the dart2js snapshot).

R=jacobr@google.com

Committed:
https://github.com/dart-lang/sdk/commit/e4733ac1457225b98c1b78f10b883ebad24fc81c
==========

[vsm, 2017-02-21 23:56:26]

Committed patchset #1 (id:1) manually as
e4733ac1457225b98c1b78f10b883ebad24fc81c (presubmit successful).