Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11053)

Unified Diff: chrome/browser/about_flags.cc

Issue 2707013002: [chrome://flags] Let features override params in the same trial (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/flags_ui/feature_entry.h » ('j') | components/flags_ui/feature_entry_macros.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/about_flags.cc
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index 91194646a73cd38c21c395d1e2811a68a7c2cab6..66f538225e246fd7d530d16b7e34b5aec8eec16d 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -1847,23 +1847,18 @@ const FeatureEntry kFeatureEntries[] = {
SINGLE_VALUE_TYPE(extensions::switches::kDisableTabForDesktopShare)},
#endif // ENABLE_EXTENSIONS
#if defined(OS_ANDROID)
- // TODO(vitaliii): Use ntp_snippets::kStudyName as the feature trial.
- // Currently, only a single FEATURE_WITH_VARIATIONS_VALUE_TYPE can use a
- // given study name. See crbug.com/690450.
{"content-suggestions-category-order",
IDS_FLAGS_CONTENT_SUGGESTIONS_CATEGORY_ORDER_NAME,
IDS_FLAGS_CONTENT_SUGGESTIONS_CATEGORY_ORDER_DESCRIPTION, kOsAndroid,
- FEATURE_WITH_VARIATIONS_VALUE_TYPE(
+ FEATURE_WITH_VARIATIONS_VALUE_TYPE_WITH_DEFAULT_TRIAL(
ntp_snippets::kCategoryOrder,
- kContentSuggestionsCategoryOrderFeatureVariations,
- "content-suggestions-category-order-feature-trial")},
+ kContentSuggestionsCategoryOrderFeatureVariations)},
{"content-suggestions-category-ranker",
IDS_FLAGS_CONTENT_SUGGESTIONS_CATEGORY_RANKER_NAME,
IDS_FLAGS_CONTENT_SUGGESTIONS_CATEGORY_RANKER_DESCRIPTION, kOsAndroid,
- FEATURE_WITH_VARIATIONS_VALUE_TYPE(
+ FEATURE_WITH_VARIATIONS_VALUE_TYPE_WITH_DEFAULT_TRIAL(
ntp_snippets::kCategoryRanker,
- kContentSuggestionsCategoryRankerFeatureVariations,
- ntp_snippets::kStudyName)},
+ kContentSuggestionsCategoryRankerFeatureVariations)},
{"override-ntp-suggestions-source", IDS_FLAGS_OVERRIDE_SNIPPETS_SOURCE_NAME,
IDS_FLAGS_OVERRIDE_SNIPPETS_SOURCE_DESCRIPTION, kOsAndroid,
FEATURE_WITH_VARIATIONS_VALUE_TYPE(ntp_snippets::kContentSuggestionsSource,
« no previous file with comments | « no previous file | components/flags_ui/feature_entry.h » ('j') | components/flags_ui/feature_entry_macros.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698