Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Side by Side Diff: chrome/browser/about_flags.cc

Issue 2707013002: [chrome://flags] Let features override params in the same trial (Closed)
Patch Set: Comments #1 Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | components/flags_ui/feature_entry.h » ('j') | components/flags_ui/feature_entry.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/about_flags.h" 5 #include "chrome/browser/about_flags.h"
6 6
7 #include <iterator> 7 #include <iterator>
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <utility> 10 #include <utility>
(...skipping 1859 matching lines...) Expand 10 before | Expand all | Expand 10 after
1870 {"disable-audio-support-for-desktop-share", 1870 {"disable-audio-support-for-desktop-share",
1871 IDS_FLAG_DISABLE_AUDIO_FOR_DESKTOP_SHARE, 1871 IDS_FLAG_DISABLE_AUDIO_FOR_DESKTOP_SHARE,
1872 IDS_FLAG_DISABLE_AUDIO_FOR_DESKTOP_SHARE_DESCRIPTION, kOsAll, 1872 IDS_FLAG_DISABLE_AUDIO_FOR_DESKTOP_SHARE_DESCRIPTION, kOsAll,
1873 SINGLE_VALUE_TYPE(switches::kDisableAudioSupportForDesktopShare)}, 1873 SINGLE_VALUE_TYPE(switches::kDisableAudioSupportForDesktopShare)},
1874 #if BUILDFLAG(ENABLE_EXTENSIONS) 1874 #if BUILDFLAG(ENABLE_EXTENSIONS)
1875 {"tab-for-desktop-share", IDS_FLAG_DISABLE_TAB_FOR_DESKTOP_SHARE, 1875 {"tab-for-desktop-share", IDS_FLAG_DISABLE_TAB_FOR_DESKTOP_SHARE,
1876 IDS_FLAG_DISABLE_TAB_FOR_DESKTOP_SHARE_DESCRIPTION, kOsAll, 1876 IDS_FLAG_DISABLE_TAB_FOR_DESKTOP_SHARE_DESCRIPTION, kOsAll,
1877 SINGLE_VALUE_TYPE(extensions::switches::kDisableTabForDesktopShare)}, 1877 SINGLE_VALUE_TYPE(extensions::switches::kDisableTabForDesktopShare)},
1878 #endif // ENABLE_EXTENSIONS 1878 #endif // ENABLE_EXTENSIONS
1879 #if defined(OS_ANDROID) 1879 #if defined(OS_ANDROID)
1880 // TODO(vitaliii): Use ntp_snippets::kStudyName as the feature trial.
1881 // Currently, only a single FEATURE_WITH_VARIATIONS_VALUE_TYPE can use a
1882 // given study name. See crbug.com/690450.
1883 {"content-suggestions-category-order", 1880 {"content-suggestions-category-order",
1884 IDS_FLAGS_CONTENT_SUGGESTIONS_CATEGORY_ORDER_NAME, 1881 IDS_FLAGS_CONTENT_SUGGESTIONS_CATEGORY_ORDER_NAME,
1885 IDS_FLAGS_CONTENT_SUGGESTIONS_CATEGORY_ORDER_DESCRIPTION, kOsAndroid, 1882 IDS_FLAGS_CONTENT_SUGGESTIONS_CATEGORY_ORDER_DESCRIPTION, kOsAndroid,
1886 FEATURE_WITH_VARIATIONS_VALUE_TYPE( 1883 FEATURE_WITH_VARIATIONS_VALUE_TYPE(
1887 ntp_snippets::kCategoryOrder, 1884 ntp_snippets::kCategoryOrder,
1888 kContentSuggestionsCategoryOrderFeatureVariations, 1885 kContentSuggestionsCategoryOrderFeatureVariations,
1889 "content-suggestions-category-order-feature-trial")}, 1886 ntp_snippets::kStudyName)},
1890 {"content-suggestions-category-ranker", 1887 {"content-suggestions-category-ranker",
1891 IDS_FLAGS_CONTENT_SUGGESTIONS_CATEGORY_RANKER_NAME, 1888 IDS_FLAGS_CONTENT_SUGGESTIONS_CATEGORY_RANKER_NAME,
1892 IDS_FLAGS_CONTENT_SUGGESTIONS_CATEGORY_RANKER_DESCRIPTION, kOsAndroid, 1889 IDS_FLAGS_CONTENT_SUGGESTIONS_CATEGORY_RANKER_DESCRIPTION, kOsAndroid,
1893 FEATURE_WITH_VARIATIONS_VALUE_TYPE( 1890 FEATURE_WITH_VARIATIONS_VALUE_TYPE(
1894 ntp_snippets::kCategoryRanker, 1891 ntp_snippets::kCategoryRanker,
1895 kContentSuggestionsCategoryRankerFeatureVariations, 1892 kContentSuggestionsCategoryRankerFeatureVariations,
1896 ntp_snippets::kStudyName)}, 1893 ntp_snippets::kStudyName)},
1897 {"override-ntp-suggestions-source", IDS_FLAGS_OVERRIDE_SNIPPETS_SOURCE_NAME, 1894 {"override-ntp-suggestions-source", IDS_FLAGS_OVERRIDE_SNIPPETS_SOURCE_NAME,
1898 IDS_FLAGS_OVERRIDE_SNIPPETS_SOURCE_DESCRIPTION, kOsAndroid, 1895 IDS_FLAGS_OVERRIDE_SNIPPETS_SOURCE_DESCRIPTION, kOsAndroid,
1899 FEATURE_WITH_VARIATIONS_VALUE_TYPE(ntp_snippets::kContentSuggestionsSource, 1896 FEATURE_WITH_VARIATIONS_VALUE_TYPE(ntp_snippets::kContentSuggestionsSource,
(...skipping 627 matching lines...) Expand 10 before | Expand all | Expand 10 after
2527 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0; 2524 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0;
2528 2525
2529 const FeatureEntry* GetFeatureEntries(size_t* count) { 2526 const FeatureEntry* GetFeatureEntries(size_t* count) {
2530 *count = arraysize(kFeatureEntries); 2527 *count = arraysize(kFeatureEntries);
2531 return kFeatureEntries; 2528 return kFeatureEntries;
2532 } 2529 }
2533 2530
2534 } // namespace testing 2531 } // namespace testing
2535 2532
2536 } // namespace about_flags 2533 } // namespace about_flags
OLDNEW
« no previous file with comments | « no previous file | components/flags_ui/feature_entry.h » ('j') | components/flags_ui/feature_entry.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698