Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(631)

Side by Side Diff: components/flags_ui/feature_entry_macros.h

Issue 2707013002: [chrome://flags] Let features override params in the same trial (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_FLAGS_UI_FEATURE_ENTRY_MACROS_H_ 5 #ifndef COMPONENTS_FLAGS_UI_FEATURE_ENTRY_MACROS_H_
6 #define COMPONENTS_FLAGS_UI_FEATURE_ENTRY_MACROS_H_ 6 #define COMPONENTS_FLAGS_UI_FEATURE_ENTRY_MACROS_H_
7 7
8 #include "base/macros.h" 8 #include "base/macros.h"
9 9
10 // Macros to simplify specifying the type of FeatureEntry. Please refer to 10 // Macros to simplify specifying the type of FeatureEntry. Please refer to
(...skipping 14 matching lines...) Expand all
25 flags_ui::FeatureEntry::ENABLE_DISABLE_VALUE, enable_switch, enable_value, \ 25 flags_ui::FeatureEntry::ENABLE_DISABLE_VALUE, enable_switch, enable_value, \
26 disable_switch, disable_value, nullptr, 3, nullptr, nullptr, nullptr 26 disable_switch, disable_value, nullptr, 3, nullptr, nullptr, nullptr
27 #define ENABLE_DISABLE_VALUE_TYPE(enable_switch, disable_switch) \ 27 #define ENABLE_DISABLE_VALUE_TYPE(enable_switch, disable_switch) \
28 ENABLE_DISABLE_VALUE_TYPE_AND_VALUE(enable_switch, "", disable_switch, "") 28 ENABLE_DISABLE_VALUE_TYPE_AND_VALUE(enable_switch, "", disable_switch, "")
29 #define MULTI_VALUE_TYPE(choices) \ 29 #define MULTI_VALUE_TYPE(choices) \
30 flags_ui::FeatureEntry::MULTI_VALUE, nullptr, nullptr, nullptr, nullptr, \ 30 flags_ui::FeatureEntry::MULTI_VALUE, nullptr, nullptr, nullptr, nullptr, \
31 nullptr, arraysize(choices), choices, nullptr, nullptr 31 nullptr, arraysize(choices), choices, nullptr, nullptr
32 #define FEATURE_VALUE_TYPE(feature) \ 32 #define FEATURE_VALUE_TYPE(feature) \
33 flags_ui::FeatureEntry::FEATURE_VALUE, nullptr, nullptr, nullptr, nullptr, \ 33 flags_ui::FeatureEntry::FEATURE_VALUE, nullptr, nullptr, nullptr, nullptr, \
34 &feature, 3, nullptr, nullptr, nullptr 34 &feature, 3, nullptr, nullptr, nullptr
35 #define FEATURE_WITH_VARIATIONS_VALUE_TYPE(feature, feature_variations, \ 35 #define FEATURE_WITH_VARIATIONS_VALUE_TYPE(feature, feature_variations, \
Alexei Svitkine (slow) 2017/02/24 16:18:20 Separately, I think we should rename FEATURE_WITH_
jkrcal 2017/02/27 08:04:36 Makes sense. Can we postpone it to another CL and
Alexei Svitkine (slow) 2017/02/28 18:45:35 Acknowledged.
jkrcal 2017/03/01 18:35:52 Added a TODO.
36 feature_trial) \ 36 feature_trial) \
37 flags_ui::FeatureEntry::FEATURE_WITH_VARIATIONS_VALUE, nullptr, nullptr, \ 37 flags_ui::FeatureEntry::FEATURE_WITH_VARIATIONS_VALUE, nullptr, nullptr, \
38 nullptr, nullptr, &feature, 3 + arraysize(feature_variations), nullptr, \ 38 nullptr, nullptr, &feature, 3 + arraysize(feature_variations), nullptr, \
39 feature_variations, feature_trial 39 feature_variations, feature_trial
40 #define FEATURE_WITH_VARIATIONS_VALUE_TYPE_WITH_DEFAULT_TRIAL( \
41 feature, feature_variations) \
42 flags_ui::FeatureEntry::FEATURE_WITH_VARIATIONS_VALUE, nullptr, nullptr, \
43 nullptr, nullptr, &feature, 3 + arraysize(feature_variations), nullptr, \
44 feature_variations, nullptr
40 45
41 #endif // COMPONENTS_FLAGS_UI_FEATURE_ENTRY_MACROS_H_ 46 #endif // COMPONENTS_FLAGS_UI_FEATURE_ENTRY_MACROS_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698