Handlify JSObject::SetObserved

src/runtime.cc

Index: src/runtime.cc
diff --git a/src/runtime.cc b/src/runtime.cc
index 77014b1771c054e1ec8da1c400b2c2533dc421b0..d133ebef41c18234465abc75614be48e7cca8d19 100644
--- a/src/runtime.cc
+++ b/src/runtime.cc
@@ -14559,7 +14559,7 @@ RUNTIME_FUNCTION(MaybeObject*, Runtime_IsObserved) {
 
 
 RUNTIME_FUNCTION(MaybeObject*, Runtime_SetIsObserved) {
-  SealHandleScope shs(isolate);
+  HandleScope scope(isolate);
   ASSERT(args.length() == 1);
   CONVERT_ARG_CHECKED(JSReceiver, obj, 0);

[Michael Starzinger, 2013/10/14 16:47:43]

Using CONVERT_ARG_HANDLE_CHECKED here will give an implicit handle within the
passed arguments (the GC knows about the position of the "args" object on the
stack). This is the cheapest way to get a handle and avoids the "js_object"
handle below.

[rafaelw, 2013/10/15 18:32:17]

Done.

   if (obj->IsJSGlobalProxy()) {
@@ -14574,7 +14574,9 @@ RUNTIME_FUNCTION(MaybeObject*, Runtime_SetIsObserved) {
   ASSERT(!(obj->map()->is_observed() && obj->IsJSObject() &&
            JSObject::cast(obj)->HasFastElements()));
   ASSERT(obj->IsJSObject());
-  return JSObject::cast(obj)->SetObserved(isolate);
+  Handle<JSObject> js_object(JSObject::cast(obj));
+  JSObject::SetObserved(js_object);

[Michael Starzinger, 2013/10/14 16:47:43]

You can use Handle<JSObject>::cast() here to do the casting.

[rafaelw, 2013/10/15 18:32:17]

Done.

+  return isolate->heap()->undefined_value();
 }