Handlify JSObject::SetObserved

Handlify JSObject::SetObserved

BUG=
R=mstarzinger@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=17224

[rafaelw, 2013-10-11 22:10:11]

first attempt: PTAL

[Michael Starzinger, 2013-10-14 16:47:42]

LGTM with one nit. Will land this once nit is addressed.

https://codereview.chromium.org/27070002/diff/5001/src/runtime.cc
File src/runtime.cc (right):

https://codereview.chromium.org/27070002/diff/5001/src/runtime.cc#newcode14564
src/runtime.cc:14564: CONVERT_ARG_CHECKED(JSReceiver, obj, 0);
Using CONVERT_ARG_HANDLE_CHECKED here will give an implicit handle within the
passed arguments (the GC knows about the position of the "args" object on the
stack). This is the cheapest way to get a handle and avoids the "js_object"
handle below.

https://codereview.chromium.org/27070002/diff/5001/src/runtime.cc#newcode14578
src/runtime.cc:14578: JSObject::SetObserved(js_object);
You can use Handle<JSObject>::cast() here to do the casting.

[Michael Starzinger, 2013-10-15 09:09:44]

Ooops, totally forgot that you are a committer now, sorry, feel free to land
this one on your own. :)

[rafaelw, 2013-10-15 18:32:16]

https://codereview.chromium.org/27070002/diff/5001/src/runtime.cc
File src/runtime.cc (right):

https://codereview.chromium.org/27070002/diff/5001/src/runtime.cc#newcode14564
src/runtime.cc:14564: CONVERT_ARG_CHECKED(JSReceiver, obj, 0);
On 2013/10/14 16:47:43, Michael Starzinger wrote:
> Using CONVERT_ARG_HANDLE_CHECKED here will give an implicit handle within the
> passed arguments (the GC knows about the position of the "args" object on the
> stack). This is the cheapest way to get a handle and avoids the "js_object"
> handle below.

Done.

https://codereview.chromium.org/27070002/diff/5001/src/runtime.cc#newcode14578
src/runtime.cc:14578: JSObject::SetObserved(js_object);
On 2013/10/14 16:47:43, Michael Starzinger wrote:
> You can use Handle<JSObject>::cast() here to do the casting.

Done.

[rafaelw, 2013-10-15 19:28:18]

Committed patchset #4 manually as r17224 (presubmit successful).