content/public/android/java/src/org/chromium/content/browser/ChildProcessCreationParams.java - Issue 2706933003: webapk: Avoid overwriting default CreationParams

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ChildProcessCreationParams.java

Issue 2706933003: webapk: Avoid overwriting default CreationParams

Patch Set: cleanups Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/site_instance_impl.cc ('K') | « content/browser/site_instance_impl_unittest.cc ('k') | content/public/browser/site_instance.h » ('j') | content/public/browser/site_instance.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/ChildProcessCreationParams.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/ChildProcessCreationParams.java b/content/public/android/java/src/org/chromium/content/browser/ChildProcessCreationParams.java

index ac1c4aeced8287a895feeafc67c7e374347a1bda..130548ed9b8fa1e7f66259eabee820fd753aca1d 100644

--- a/content/public/android/java/src/org/chromium/content/browser/ChildProcessCreationParams.java

+++ b/content/public/android/java/src/org/chromium/content/browser/ChildProcessCreationParams.java

@@ -19,7 +19,7 @@ public class ChildProcessCreationParams {

private static final String EXTRA_LIBRARY_PROCESS_TYPE =

"org.chromium.content.common.child_service_params.library_process_type";

- public static final int DEFAULT_ID = 0;

+ public static final int DEFAULT_ID = 0; // Must match ChildProcessLauncher::DEFAULT_PARAM_ID.

private static final Object sLock = new Object();

private static int sNextId = 1; // 0 is reserved for DEFAULT_ID.

private static final SparseArray<ChildProcessCreationParams> sParamMap = new SparseArray<>();