Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Unified Diff: content/browser/android/child_process_launcher_android.cc

Issue 2706933003: webapk: Avoid overwriting default CreationParams
Patch Set: cleanups Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/android/child_process_launcher_android.cc
diff --git a/content/browser/android/child_process_launcher_android.cc b/content/browser/android/child_process_launcher_android.cc
index 43b1396c7291eef31108c2a916bcd1b309d3cb80..411138724308828bcaea9f4c124bcfa355717316 100644
--- a/content/browser/android/child_process_launcher_android.cc
+++ b/content/browser/android/child_process_launcher_android.cc
@@ -56,11 +56,11 @@ static void OnChildProcessStarted(JNIEnv*,
delete callback;
}
-void StartChildProcess(
- const base::CommandLine::StringVector& argv,
- int child_process_id,
- content::FileDescriptorInfo* files_to_register,
- const StartChildProcessCallback& callback) {
+void StartChildProcess(const base::CommandLine::StringVector& argv,
+ int child_process_id,
+ content::FileDescriptorInfo* files_to_register,
+ int child_process_param_id,
+ const StartChildProcessCallback& callback) {
JNIEnv* env = AttachCurrentThread();
DCHECK(env);
@@ -92,10 +92,9 @@ void StartChildProcess(
}
}
- constexpr int param_key = 0; // TODO(boliu): Use this.
Java_ChildProcessLauncher_start(
- env, base::android::GetApplicationContext(), param_key, j_argv,
- child_process_id, j_file_infos,
+ env, base::android::GetApplicationContext(), child_process_param_id,
+ j_argv, child_process_id, j_file_infos,
reinterpret_cast<intptr_t>(new StartChildProcessCallback(callback)));
}

Powered by Google App Engine
This is Rietveld 408576698