chrome/test/android/javatests/src/org/chromium/chrome/test/util/PrerenderTestHelper.java - Issue 2706933003: webapk: Avoid overwriting default CreationParams

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/android/javatests/src/org/chromium/chrome/test/util/PrerenderTestHelper.java

Issue 2706933003: webapk: Avoid overwriting default CreationParams

Patch Set: cleanups Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/WarmupManager.java ('K') | « chrome/browser/android/web_contents_factory.cc ('k') | content/browser/android/child_process_launcher_android.h » ('j') | content/browser/site_instance_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/android/javatests/src/org/chromium/chrome/test/util/PrerenderTestHelper.java

diff --git a/chrome/test/android/javatests/src/org/chromium/chrome/test/util/PrerenderTestHelper.java b/chrome/test/android/javatests/src/org/chromium/chrome/test/util/PrerenderTestHelper.java

index 4ac91c48da788267472246c63c9cb66a1d6c6c10..2c0f296cb1e5375bf5639150fb766283f6d85bd8 100644

--- a/chrome/test/android/javatests/src/org/chromium/chrome/test/util/PrerenderTestHelper.java

+++ b/chrome/test/android/javatests/src/org/chromium/chrome/test/util/PrerenderTestHelper.java

@@ -13,6 +13,7 @@ import org.chromium.chrome.browser.TabLoadStatus;

import org.chromium.chrome.browser.prerender.ExternalPrerenderHandler;

import org.chromium.chrome.browser.tab.Tab;

import org.chromium.chrome.test.ChromeTabbedActivityTestBase;

+import org.chromium.content.browser.ChildProcessCreationParams;

import org.chromium.content.browser.test.util.Criteria;

import org.chromium.content.browser.test.util.CriteriaHelper;

@@ -100,7 +101,8 @@ public class PrerenderTestHelper {

.getContentHeightPixInt());

boolean didPrerender =

prerenderHandler.addPrerender(currentTab.getProfile(),

- currentTab.getWebContents(), testUrl, null, bounds, true)

+ currentTab.getWebContents(), testUrl, null, bounds, true,

+ ChildProcessCreationParams.DEFAULT_ID)

!= null;

Assert.assertTrue("Failed to prerender test url: " + testUrl, didPrerender);

return prerenderHandler;