chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java - Issue 2706933003: webapk: Avoid overwriting default CreationParams

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java

Issue 2706933003: webapk: Avoid overwriting default CreationParams

Patch Set: cleanups Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/WarmupManager.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/tab/TabDelegateFactory.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java » ('j') | content/browser/site_instance_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java b/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java

index 20b26f4d5eb4b31195b8858f423f10154f3b9560..c3540c2a38de1e9f0662fb6ce2db2e7878996a8c 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java

@@ -39,6 +39,7 @@ import org.chromium.chrome.browser.tabmodel.TabModel;

import org.chromium.chrome.browser.tabmodel.TabModelSelector;

import org.chromium.chrome.browser.tabmodel.TabModelSelectorObserver;

import org.chromium.chrome.browser.tabmodel.TabModelSelectorTabObserver;

+import org.chromium.content.browser.ChildProcessCreationParams;

import org.chromium.content.browser.ContentView;

import org.chromium.content.browser.ContentViewCore;

import org.chromium.content_public.browser.LoadUrlParams;

@@ -260,7 +261,8 @@ public class VrShellImpl extends GvrLayout implements VrShell, SurfaceHolder.Cal

mContentVrWindowAndroid = new VrWindowAndroid(mActivity, mContentVirtualDisplay);

mUiVrWindowAndroid = new VrWindowAndroid(mActivity, mUiVirtualDisplay);

- mUiContents = WebContentsFactory.createWebContents(true, false);

+ mUiContents = WebContentsFactory.createWebContents(

+ ChildProcessCreationParams.DEFAULT_ID, true, false);

mUiCVC = new ContentViewCore(mActivity, ChromeVersionInfo.getProductVersion());

ContentView uiContentView = ContentView.createContentView(mActivity, mUiCVC);

mUiCVC.initialize(ViewAndroidDelegate.createBasicDelegate(uiContentView),