Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2593)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelContent.java

Issue 2706933003: webapk: Avoid overwriting default CreationParams
Patch Set: cleanups Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelContent.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelContent.java b/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelContent.java
index 350e752efd7b4314e0aea6c411385a65a1e7c099..82debb450bfa02bac3fd6e0e0713fce3c1e0f43e 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelContent.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelContent.java
@@ -20,6 +20,7 @@ import org.chromium.chrome.browser.tab.Tab;
import org.chromium.components.navigation_interception.InterceptNavigationDelegate;
import org.chromium.components.navigation_interception.NavigationParams;
import org.chromium.components.web_contents_delegate_android.WebContentsDelegateAndroid;
+import org.chromium.content.browser.ChildProcessCreationParams;
import org.chromium.content.browser.ContentVideoViewEmbedder;
import org.chromium.content.browser.ContentView;
import org.chromium.content.browser.ContentViewCore;
@@ -265,7 +266,12 @@ public class OverlayPanelContent {
}
// Creates an initially hidden WebContents which gets shown when the panel is opened.
- WebContents panelWebContents = WebContentsFactory.createWebContents(false, true);
+ int paramsId = ChildProcessCreationParams.DEFAULT_ID;
+ Tab parentTab = mActivity.getActivityTab();
+ if (parentTab != null) {
+ paramsId = parentTab.getDelegateFactory().getChildProcessParamId();
+ }
+ WebContents panelWebContents = WebContentsFactory.createWebContents(paramsId, false, true);
// Dummny ViewAndroidDelegate since the container view for overlay panel is
// never added to the view hierarchy.

Powered by Google App Engine
This is Rietveld 408576698