content/browser/frame_host/navigation_entry_impl_unittest.cc - Issue 2706933003: webapk: Avoid overwriting default CreationParams

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigation_entry_impl_unittest.cc

Issue 2706933003: webapk: Avoid overwriting default CreationParams

Patch Set: rebase 461342 Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/frame_host/navigation_entry_impl_unittest.cc

diff --git a/content/browser/frame_host/navigation_entry_impl_unittest.cc b/content/browser/frame_host/navigation_entry_impl_unittest.cc

index e47fab03b811119d14c6f4f418eb57c908bbd4dc..c3a4d57b3455b435b86cf3b48c04a9c087b8264e 100644

--- a/content/browser/frame_host/navigation_entry_impl_unittest.cc

+++ b/content/browser/frame_host/navigation_entry_impl_unittest.cc

@@ -24,7 +24,7 @@ class NavigationEntryTest : public testing::Test {

void SetUp() override {

entry1_.reset(new NavigationEntryImpl);

- instance_ = SiteInstanceImpl::Create(NULL);

+ instance_ = SiteInstanceImpl::Create(nullptr, 0);

entry2_.reset(new NavigationEntryImpl(

instance_,

GURL("test:url"),