Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2594)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/WarmupManagerTest.java

Issue 2706933003: webapk: Avoid overwriting default CreationParams
Patch Set: rebase 461342 Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/javatests/src/org/chromium/chrome/browser/WarmupManagerTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/WarmupManagerTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/WarmupManagerTest.java
index 0b5cf3919110c914b3674202a329b37f4ebda529..1d113164b07637dd772ebff6c4b53fd0637f6b15 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/WarmupManagerTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/WarmupManagerTest.java
@@ -20,6 +20,7 @@ import org.junit.Test;
import org.junit.runner.RunWith;
import org.chromium.base.ThreadUtils;
+import org.chromium.base.process_launcher.ChildProcessCreationParams;
import org.chromium.base.test.BaseJUnit4ClassRunner;
import org.chromium.base.test.util.Restriction;
import org.chromium.chrome.R;
@@ -89,7 +90,8 @@ public class WarmupManagerTest {
public void run() {
mWarmupManager.createSpareWebContents();
Assert.assertTrue(mWarmupManager.hasSpareWebContents());
- WebContents webContents = mWarmupManager.takeSpareWebContents(false, false);
+ WebContents webContents = mWarmupManager.takeSpareWebContents(
+ false, false, ChildProcessCreationParams.DEFAULT_ID);
Assert.assertNotNull(webContents);
Assert.assertFalse(mWarmupManager.hasSpareWebContents());
WebContentsObserver observer = new WebContentsObserver(webContents) {
@@ -128,7 +130,8 @@ public class WarmupManagerTest {
@Override
public void run() {
mWarmupManager.createSpareWebContents();
- WebContents webContents = mWarmupManager.takeSpareWebContents(false, false);
+ WebContents webContents = mWarmupManager.takeSpareWebContents(
+ false, false, ChildProcessCreationParams.DEFAULT_ID);
Assert.assertNotNull(webContents);
Assert.assertFalse(mWarmupManager.hasSpareWebContents());
webContents.destroy();
@@ -144,9 +147,12 @@ public class WarmupManagerTest {
@Override
public void run() {
mWarmupManager.createSpareWebContents();
- Assert.assertNull(mWarmupManager.takeSpareWebContents(true, false));
- Assert.assertNull(mWarmupManager.takeSpareWebContents(false, true));
- Assert.assertNull(mWarmupManager.takeSpareWebContents(true, true));
+ Assert.assertNull(mWarmupManager.takeSpareWebContents(
+ true, false, ChildProcessCreationParams.DEFAULT_ID));
+ Assert.assertNull(mWarmupManager.takeSpareWebContents(
+ false, true, ChildProcessCreationParams.DEFAULT_ID));
+ Assert.assertNull(mWarmupManager.takeSpareWebContents(
+ true, true, ChildProcessCreationParams.DEFAULT_ID));
Assert.assertTrue(mWarmupManager.hasSpareWebContents());
}
});

Powered by Google App Engine
This is Rietveld 408576698