Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2733)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelContent.java

Issue 2706933003: webapk: Avoid overwriting default CreationParams
Patch Set: rebase 461342 Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelContent.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelContent.java b/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelContent.java
index f816d14fbcec6d0212b8915e99708aad8575b526..f1c0d2c51895118a8eb35c928867c7d13f2aa244 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelContent.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelContent.java
@@ -11,6 +11,7 @@ import android.view.ViewGroup;
import org.chromium.base.VisibleForTesting;
import org.chromium.base.annotations.CalledByNative;
+import org.chromium.base.process_launcher.ChildProcessCreationParams;
import org.chromium.chrome.browser.ChromeActivity;
import org.chromium.chrome.browser.ChromeVersionInfo;
import org.chromium.chrome.browser.WebContentsFactory;
@@ -265,7 +266,12 @@ public class OverlayPanelContent {
}
// Creates an initially hidden WebContents which gets shown when the panel is opened.
- WebContents panelWebContents = WebContentsFactory.createWebContents(false, true);
+ int paramsId = ChildProcessCreationParams.DEFAULT_ID;
+ Tab parentTab = mActivity.getActivityTab();
+ if (parentTab != null) {
+ paramsId = parentTab.getDelegateFactory().getChildProcessParamId();
+ }
+ WebContents panelWebContents = WebContentsFactory.createWebContents(paramsId, false, true);
// Dummny ViewAndroidDelegate since the container view for overlay panel is
// never added to the view hierarchy.

Powered by Google App Engine
This is Rietveld 408576698