Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(888)

Unified Diff: Source/devtools/front_end/timeline/CountersGraph.js

Issue 270693003: Timeline: make frames in TimelineView selectable (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/timeline/CountersGraph.js
diff --git a/Source/devtools/front_end/timeline/CountersGraph.js b/Source/devtools/front_end/timeline/CountersGraph.js
index a53e4f4042773c05b6e6b93312084002948e4bab..a63f9dd9a730e416551db1af4650a540f4a99b57 100644
--- a/Source/devtools/front_end/timeline/CountersGraph.js
+++ b/Source/devtools/front_end/timeline/CountersGraph.js
@@ -195,7 +195,7 @@ WebInspector.CountersGraph.prototype = {
return false;
}
this._model.forAllRecords(null, findRecordToReveal.bind(this));
- this._delegate.selectRecord(recordToReveal);
+ this._delegate.select(recordToReveal ? WebInspector.TimelineSelection.fromRecord(recordToReveal) : null);
},
/**
@@ -258,9 +258,9 @@ WebInspector.CountersGraph.prototype = {
},
/**
- * @param {?WebInspector.TimelineModel.Record} record
+ * @param {?WebInspector.TimelineSelection} selection
*/
- setSelectedRecord: function(record)
+ setSelection: function(selection)
{
},

Powered by Google App Engine
This is Rietveld 408576698