Issue 270693003: Timeline: make frames in TimelineView selectable

Issue 270693003: Timeline: make frames in TimelineView selectable (Closed)

Created:
6 years, 7 months ago by caseq

Modified:
6 years, 7 months ago

Reviewers:
pfeldman, yurys, loislo

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Timeline: make frames in TimelineView selectable - generalize selection in timeline, so we can select multiple types of objects (currently, just records and frames); - make frame bars in the top of classic Timeline view selectable (mutually exclusive with selected records on the left); - move contents of frame details popover into details view; BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173656

Patch Set 1 #

Total comments: 1

Patch Set 2 : bail out early if selection is of wrong type #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+174 lines, -63 lines)			Patch
M	Source/devtools/front_end/timeline/CountersGraph.js	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	Source/devtools/front_end/timeline/TimelineFlameChart.js	View	1	2 chunks	+8 lines, -3 lines	0 comments	Download
M	Source/devtools/front_end/timeline/TimelinePanel.js	View		9 chunks	+96 lines, -33 lines	0 comments	Download
M	Source/devtools/front_end/timeline/TimelineTracingView.js	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/devtools/front_end/timeline/TimelineView.js	View		11 chunks	+59 lines, -21 lines	0 comments	Download
M	Source/devtools/front_end/timelinePanel.css	View		2 chunks	+6 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

yurys

lgtm https://codereview.chromium.org/270693003/diff/1/Source/devtools/front_end/timeline/TimelineFlameChart.js File Source/devtools/front_end/timeline/TimelineFlameChart.js (right): https://codereview.chromium.org/270693003/diff/1/Source/devtools/front_end/timeline/TimelineFlameChart.js#newcode881 Source/devtools/front_end/timeline/TimelineFlameChart.js:881: var record = selection && selection.object(); May be ...

6 years, 7 months ago (2014-05-08 14:56:30 UTC) #2

caseq

On 2014/05/08 14:56:30, yurys wrote: > > https://codereview.chromium.org/270693003/diff/1/Source/devtools/front_end/timeline/TimelineFlameChart.js#newcode881 > Source/devtools/front_end/timeline/TimelineFlameChart.js:881: var record = > selection ...

6 years, 7 months ago (2014-05-08 15:57:22 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/caseq@chromium.org/270693003/20001

6 years, 7 months ago (2014-05-08 15:58:29 UTC) #5

Message was sent while issue was closed.

Change committed as 173656

Expand Messages | Collapse Messages