Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Unified Diff: content/browser/service_worker/service_worker_metrics.cc

Issue 2706923003: Add UMA for how long service workers run for. (Closed)
Patch Set: tweaks, fmt Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_metrics.cc
diff --git a/content/browser/service_worker/service_worker_metrics.cc b/content/browser/service_worker/service_worker_metrics.cc
index aa0aa0862133853c59e79b0674dfe8427ddb54a9..a9a5e91de3a10ca63e2537969fe053c3eaae1003 100644
--- a/content/browser/service_worker/service_worker_metrics.cc
+++ b/content/browser/service_worker/service_worker_metrics.cc
@@ -978,4 +978,19 @@ void ServiceWorkerMetrics::RecordContextRequestHandlerStatus(
}
}
+void ServiceWorkerMetrics::RecordRuntime(base::TimeDelta time) {
+ // Start at 1 second since we expect service worker to last at least this
+ // long: the update timer and idle timeout timer run on the order of seconds.
+ constexpr base::TimeDelta kMin = base::TimeDelta::FromSeconds(1);
+ // End at 1 day since service workers can conceivably run as long as the the
+ // browser is open; we have to cap somewhere.
+ constexpr base::TimeDelta kMax = base::TimeDelta::FromDays(1);
+ // Set the bucket count to 50 since that is the recommended value for all
+ // histograms.
+ const int kBucketCount = 50;
+
+ UMA_HISTOGRAM_CUSTOM_TIMES("ServiceWorker.Runtime", time, kMin, kMax,
+ kBucketCount);
+}
+
} // namespace content
« no previous file with comments | « content/browser/service_worker/service_worker_metrics.h ('k') | content/browser/service_worker/service_worker_version.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698