third_party/WebKit/LayoutTests/fast/dom/Window/resources/window-property-collector.js - Issue 2706923002: Rework security checks to be based on Window rather than Frame.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/dom/Window/resources/window-property-collector.js

Issue 2706923002: Rework security checks to be based on Window rather than Frame. (Closed)

Patch Set: Do not hardcode V8Window::wrapperTypeInfo Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-expected.txt ('k') | third_party/WebKit/LayoutTests/http/tests/security/detached-window-cross-origin-access.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/dom/Window/resources/window-property-collector.js

diff --git a/third_party/WebKit/LayoutTests/fast/dom/Window/resources/window-property-collector.js b/third_party/WebKit/LayoutTests/fast/dom/Window/resources/window-property-collector.js

index fd228a0a94ddf534a55eeb54a2f0000a00f6ff36..826e4c7871ece8912aec6fb17241305b983553a8 100644

--- a/third_party/WebKit/LayoutTests/fast/dom/Window/resources/window-property-collector.js

+++ b/third_party/WebKit/LayoutTests/fast/dom/Window/resources/window-property-collector.js

@@ -25,7 +25,10 @@ function emitExpectedResult(path, expected)

// Skip the properties which are hard to expect a stable result.

if (path[0] == 'accessibilityController' // we can hardly estimate the states of the cached WebAXObjects.

- || path[0] == 'localStorage') { // local storage is not reliably cleared between tests.

+ // TODO(https://crbug.com/698610): Web storage APIs are not being

+ // cleared between tests.

+ || path[0] == 'localStorage'

+ || path[0] == 'sessionStorage') {

return;

}