third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-navigated.html - Issue 2706923002: Rework security checks to be based on Window rather than Frame.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-navigated.html

Issue 2706923002: Rework security checks to be based on Window rather than Frame. (Closed)

Patch Set: Do not hardcode V8Window::wrapperTypeInfo Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/dom/Window/orphaned-frame-access-expected.txt ('k') | third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-navigated-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-navigated.html

diff --git a/third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-navigated.html b/third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-navigated.html

index ef964a1d64692ef746bbe6f72002053c0664feda..2d0711778393e7db6cd667fb09df66a6aa20d01b 100644

--- a/third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-navigated.html

+++ b/third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-navigated.html

@@ -14,9 +14,6 @@ function insertExpectedResult(path, expected)

if (path.length < 2)

return;

var propertyDir = path.slice(0, -1).join('.');

- // Cached Location properties become undefined.

- if (propertyDir == "location")

- expected = "undefined";

var cachedPropertyDir = "cached_" + propertyDir.replace('.', '_');

window[cachedPropertyDir] = eval("childWindow." + propertyDir);

propertiesToVerify.push({

@@ -32,7 +29,8 @@ function runTest()

childWindow = frame.contentWindow;

// Have expected results assume that the frame hasn't been closed (=> window.closed = false.)

collectProperties(document.getElementById("src_frame").contentWindow, false);

- frame.src = 'about:blank';

+ frame.onload = testFrameLoaded;

+ frame.src = 'data:text/plain,';

}

function testFrameLoaded()

@@ -47,6 +45,6 @@ function testFrameLoaded()

</head>

-<iframe id="test_frame" src="resources/blank.html" onload="testFrameLoaded()"></iframe>

+<iframe id="test_frame"></iframe>

</body>

</html>