Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Unified Diff: third_party/WebKit/Source/bindings/templates/interface_base.cpp.tmpl

Issue 2706923002: Rework security checks to be based on Window rather than Frame. (Closed)
Patch Set: Meh Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/templates/interface_base.cpp.tmpl
diff --git a/third_party/WebKit/Source/bindings/templates/interface_base.cpp.tmpl b/third_party/WebKit/Source/bindings/templates/interface_base.cpp.tmpl
index f57a236adea40be7d879a36661d1f522ec1c3918..7824f469f35039bfaccc6e5a8acc85a30bfb1743 100644
--- a/third_party/WebKit/Source/bindings/templates/interface_base.cpp.tmpl
+++ b/third_party/WebKit/Source/bindings/templates/interface_base.cpp.tmpl
@@ -273,7 +273,8 @@ void {{v8_class_or_partial}}::crossOriginNamedGetter(v8::Local<v8::Name> name, c
{% else %}
BindingSecurity::FailedAccessCheckFor(
info.GetIsolate(),
- {{v8_class}}::toImpl(info.Holder())->GetFrame());
+ &{{v8_class}}::wrapperTypeInfo,
+ info.Holder());
{% endif %}
}
{% endif %}
@@ -297,7 +298,8 @@ void {{v8_class_or_partial}}::crossOriginNamedSetter(v8::Local<v8::Name> name, v
BindingSecurity::FailedAccessCheckFor(
info.GetIsolate(),
- {{v8_class}}::toImpl(info.Holder())->GetFrame());
+ &{{v8_class}}::wrapperTypeInfo,
+ info.Holder());
}
{% endif %}

Powered by Google App Engine
This is Rietveld 408576698