third_party/WebKit/Source/core/frame/Location.h - Issue 2706923002: Rework security checks to be based on Window rather than Frame.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/Location.h

Issue 2706923002: Rework security checks to be based on Window rather than Frame. (Closed)

Patch Set: Address review comments. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/frame/Location.h

diff --git a/third_party/WebKit/Source/core/frame/Location.h b/third_party/WebKit/Source/core/frame/Location.h

index 12fc28031f710ad5477417d0fece231cf307c1e0..359b6196d345d4cbd626a605ac254b95b84f8214 100644

--- a/third_party/WebKit/Source/core/frame/Location.h

+++ b/third_party/WebKit/Source/core/frame/Location.h

@@ -58,8 +58,6 @@ class CORE_EXPORT Location final : public GarbageCollected<Location>,

}

DOMWindow* domWindow() const { return m_domWindow.get(); }

- // TODO(dcheng): Deprecated and will be removed. Do not use in new code!

- Frame* frame() const { return m_domWindow->frame(); }

void setHref(LocalDOMWindow* currentWindow,

LocalDOMWindow* enteredWindow,