Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8DOMWrapper.cpp

Issue 2706923002: Rework security checks to be based on Window rather than Frame. (Closed)
Patch Set: Address review comments. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/V8DOMWrapper.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8DOMWrapper.cpp b/third_party/WebKit/Source/bindings/core/v8/V8DOMWrapper.cpp
index e54c2acf6f2f81002f2fe5dd3640bf024dbe2a32..59f5677559acbf7235778ede262e3bf6aee9c904 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8DOMWrapper.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/V8DOMWrapper.cpp
@@ -119,9 +119,10 @@ void V8WrapperInstantiationScope::securityCheck(
// reach this code path. Should be generalized.
ExceptionState exceptionState(isolate, ExceptionState::ConstructionContext,
"Location");
- if (BindingSecurity::shouldAllowAccessToDetachedWindow(
- callingWindow, targetWindow, exceptionState))
+ if (BindingSecurity::shouldAllowAccessTo(callingWindow, targetWindow,
+ exceptionState)) {
return;
+ }
CHECK_EQ(SecurityError, exceptionState.code());
return;

Powered by Google App Engine
This is Rietveld 408576698