third_party/WebKit/Source/web/WebLocalFrameImpl.cpp - Issue 2706923002: Rework security checks to be based on Window rather than Frame.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

Issue 2706923002: Rework security checks to be based on Window rather than Frame. (Closed)

Patch Set: Fix test typo Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

diff --git a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

index a95f10fc30b00e4b0c321788ff8a452a85917c96..1dcd17f8c92e6c1c3fa168b29f304125bf9ac3de 100644

--- a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

+++ b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

@@ -834,7 +834,7 @@ v8::Local<v8::Context> WebLocalFrameImpl::mainWorldScriptContext() const {

bool WebFrame::scriptCanAccess(WebFrame* target) {

return BindingSecurity::shouldAllowAccessToFrame(

- currentDOMWindow(mainThreadIsolate()), target->toImplBase()->frame(),

+ currentDOMWindow(mainThreadIsolate()), *target->toImplBase()->frame(),

BindingSecurity::ErrorReportOption::DoNotReport);

}