third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp - Issue 2706923002: Rework security checks to be based on Window rather than Frame.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp

Issue 2706923002: Rework security checks to be based on Window rather than Frame. (Closed)

Patch Set: Fix test typo Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp b/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp

index d2022d0510e64ea3cc9776c9129f33ba85a34938..f562562a10c9d45b03b9ff5ef61cb9a9f3e0a503 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp

@@ -655,7 +655,7 @@ v8::MaybeLocal<v8::Value> V8ScriptRunner::callFunction(

DCHECK(!frame ||

BindingSecurity::shouldAllowAccessToFrame(

toDOMWindow(function->CreationContext())->toLocalDOMWindow(),

- frame, BindingSecurity::ErrorReportOption::DoNotReport));

+ *frame, BindingSecurity::ErrorReportOption::DoNotReport));

CHECK(!ThreadState::current()->isWrapperTracingForbidden());

v8::MicrotasksScope microtasksScope(isolate,

v8::MicrotasksScope::kRunMicrotasks);