Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScheduledAction.cpp

Issue 2706923002: Rework security checks to be based on Window rather than Frame. (Closed)
Patch Set: Fix test typo Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/ScheduledAction.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/ScheduledAction.cpp b/third_party/WebKit/Source/bindings/core/v8/ScheduledAction.cpp
index 1f40c6b0867dbdae9df028e20926770b48a1c814..ec9cf2ffcf449acce1010a1855976bbf4d5a77ca 100644
--- a/third_party/WebKit/Source/bindings/core/v8/ScheduledAction.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/ScheduledAction.cpp
@@ -53,7 +53,7 @@ ScheduledAction* ScheduledAction::create(ScriptState* scriptState,
ASSERT(handler.isFunction());
if (!scriptState->world().isWorkerWorld()) {
DCHECK(BindingSecurity::shouldAllowAccessToFrame(
- enteredDOMWindow(scriptState->isolate()), toDocument(target)->frame(),
+ enteredDOMWindow(scriptState->isolate()), *toDocument(target)->frame(),
BindingSecurity::ErrorReportOption::DoNotReport));
}
return new ScheduledAction(scriptState, handler, arguments);
@@ -64,7 +64,7 @@ ScheduledAction* ScheduledAction::create(ScriptState* scriptState,
const String& handler) {
if (!scriptState->world().isWorkerWorld()) {
DCHECK(BindingSecurity::shouldAllowAccessToFrame(
- enteredDOMWindow(scriptState->isolate()), toDocument(target)->frame(),
+ enteredDOMWindow(scriptState->isolate()), *toDocument(target)->frame(),
BindingSecurity::ErrorReportOption::DoNotReport));
}
return new ScheduledAction(scriptState, handler);

Powered by Google App Engine
This is Rietveld 408576698