Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(799)

Unified Diff: third_party/WebKit/Source/core/testing/Internals.cpp

Issue 2706913003: FrameView can be null in addTextMatchMaker() after appendChild(iframe) (Closed)
Patch Set: Rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/testing/Internals.cpp
diff --git a/third_party/WebKit/Source/core/testing/Internals.cpp b/third_party/WebKit/Source/core/testing/Internals.cpp
index c13b7b919ecaf60e10933212f232a8481f64116a..9125fef91a77a15662bf5a97258eba0e7688824d 100644
--- a/third_party/WebKit/Source/core/testing/Internals.cpp
+++ b/third_party/WebKit/Source/core/testing/Internals.cpp
@@ -1047,7 +1047,8 @@ void Internals::addTextMatchMarker(const Range* range, bool isActive) {
// This simulates what the production code does after
// DocumentMarkerController::addTextMatchMarker().
- range->ownerDocument().view()->invalidatePaintForTickmarks();
+ if (range->ownerDocument().view())
yosin_UTC9 2017/02/21 23:24:17 Could you do early return at top of function, e.g.
hiroshige 2017/02/21 23:29:56 Done.
+ range->ownerDocument().view()->invalidatePaintForTickmarks();
}
static bool parseColor(const String& value,

Powered by Google App Engine
This is Rietveld 408576698