MacViews/a11y: Disable most text-specific attributes for protected textfields.

ui/views/widget/native_widget_mac_accessibility_unittest.mm

Index: ui/views/widget/native_widget_mac_accessibility_unittest.mm
diff --git a/ui/views/widget/native_widget_mac_accessibility_unittest.mm b/ui/views/widget/native_widget_mac_accessibility_unittest.mm
index 7d26ab8301a39a32874a0c47946860fefdd93aab..924e79f1ae83016170050b4e7bda4a151b21db41 100644
--- a/ui/views/widget/native_widget_mac_accessibility_unittest.mm
+++ b/ui/views/widget/native_widget_mac_accessibility_unittest.mm
@@ -6,6 +6,7 @@
 
 #import <Cocoa/Cocoa.h>
 
+#include "base/strings/stringprintf.h"
 #include "base/strings/sys_string_conversions.h"
 #include "base/strings/utf_string_conversions.h"
 #import "testing/gtest_mac.h"
@@ -461,4 +462,52 @@ TEST_F(NativeWidgetMacAccessibilityTest, PressAction) {
   EXPECT_TRUE(view->mouse_was_pressed());
 }
 
+// Test text-specific attributes that should not be supported for protected
+// textfields.
+TEST_F(NativeWidgetMacAccessibilityTest, ProtectedTextfields) {
+  Textfield* textfield = AddChildTextfield(GetWidgetBounds().size());
+  textfield->SetTextInputType(ui::TEXT_INPUT_TYPE_PASSWORD);
+
+  // Get the Textfield accessibility object.
+  NSPoint midpoint = gfx::ScreenPointToNSPoint(GetWidgetBounds().CenterPoint());
+  id ax_node = [widget()->GetNativeWindow() accessibilityHitTest:midpoint];
+  EXPECT_TRUE(ax_node);
+
+  // Create a native Cocoa NSSecureTextField to compare against.
+  base::scoped_nsobject<NSSecureTextField> cocoa_secure_textfield(
+      [[NSSecureTextField alloc] initWithFrame:NSMakeRect(0, 0, 10, 10)]);
+
+  NSArray* views_attributes = [ax_node accessibilityAttributeNames];
+  NSArray* cocoa_attributes =
+      [cocoa_secure_textfield accessibilityAttributeNames];
+
+  NSArray* const expected_supported_attributes = @[
+    NSAccessibilityValueAttribute, NSAccessibilityPlaceholderValueAttribute
+  ];
+  NSArray* const expected_unsupported_attributes = @[
+    NSAccessibilitySelectedTextAttribute,
+    NSAccessibilitySelectedTextRangeAttribute,
+    NSAccessibilityNumberOfCharactersAttribute,
+    NSAccessibilityVisibleCharacterRangeAttribute,
+    NSAccessibilityInsertionPointLineNumberAttribute
+  ];
+
+  for (NSString* attribute_name in expected_supported_attributes) {
+    // Don't check Cocoa's attribute values for PlaceHolder and Value here -
+    // there are inconsistencies where they will show up in the Accessibility
+    // Inspector but aren't reported by -accessibilityAttributeNames.

[tapted, 2017/02/23 06:20:34]

Is there any use in something like:

if (base::mac::IsOSAtLeast_10.10()) {
  EXPECT_TRUE([cocoa_secure_textfield
isAccessibilitySelectorAllowed:@selector(accessibilityPlaceholderValue)]);
  EXPECT_TRUE([cocoa_secure_textfield
isAccessibilitySelectorAllowed:@selector(accessibilityValue)]);
}

?

[Patti Lor, 2017/02/24 04:36:14]

Yep! That works, thanks for the suggestion and the help offline.

+    SCOPED_TRACE(base::SysNSStringToUTF8([NSString
+        stringWithFormat:@"Missing attribute is: %@", attribute_name]));
+    EXPECT_TRUE([views_attributes containsObject:attribute_name]);
+  }
+  EXPECT_FALSE(
+      [ax_node accessibilityIsAttributeSettable:NSAccessibilityValueAttribute]);
+  for (NSString* attribute_name in expected_unsupported_attributes) {
+    SCOPED_TRACE(base::SysNSStringToUTF8([NSString
+        stringWithFormat:@"Missing attribute is: %@", attribute_name]));
+    EXPECT_FALSE([views_attributes containsObject:attribute_name]);
+    EXPECT_FALSE([cocoa_attributes containsObject:attribute_name]);

[tapted, 2017/02/23 06:20:34]

so what _is_ in cocoa_attributes?


It's possible with this changing API we're going to get a lot of
OS-version-specific behaviour.. argh. I guess we need to consider that we may
have a period of mess where we need some way to map between the two APIs so that
we can run the same a11y code on 10.9 and 10.10+

i.e. perhaps AppKit on 10.10+ have already started assuming that nothing will
ever query its native controls using the old APIs, so they do nothing.

I'm not sure it's worth maintaining some kind of mapping if we just need it for
tests.

[Patti Lor, 2017/02/24 04:36:14]

Erm, pretty much everything is still in |cocoa_attributes| (at least for
password fields). I think "AXTitle" is missing and "AXSubrole" (along with the
Value and PlaceholderValue). But yeah, not really sure what to do about that
either, but also agree it's not worth it for tests only. :(

+  }
+}
+
 }  // namespace views