Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1017)

Side by Side Diff: ui/views/widget/native_widget_mac_accessibility_unittest.mm

Issue 2706743002: MacViews/a11y: Disable most text-specific attributes for protected textfields. (Closed)
Patch Set: Review comments. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ui/accessibility/platform/ax_platform_node_mac.mm ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <memory> 5 #include <memory>
6 6
7 #import <Cocoa/Cocoa.h> 7 #import <Cocoa/Cocoa.h>
8 8
9 #include "base/mac/mac_util.h"
10 #import "base/mac/sdk_forward_declarations.h"
11 #include "base/strings/stringprintf.h"
9 #include "base/strings/sys_string_conversions.h" 12 #include "base/strings/sys_string_conversions.h"
10 #include "base/strings/utf_string_conversions.h" 13 #include "base/strings/utf_string_conversions.h"
11 #import "testing/gtest_mac.h" 14 #import "testing/gtest_mac.h"
12 #include "ui/accessibility/ax_enums.h" 15 #include "ui/accessibility/ax_enums.h"
13 #include "ui/accessibility/ax_node_data.h" 16 #include "ui/accessibility/ax_node_data.h"
14 #import "ui/accessibility/platform/ax_platform_node_mac.h" 17 #import "ui/accessibility/platform/ax_platform_node_mac.h"
15 #include "ui/base/ime/text_input_type.h" 18 #include "ui/base/ime/text_input_type.h"
16 #import "ui/gfx/mac/coordinate_conversion.h" 19 #import "ui/gfx/mac/coordinate_conversion.h"
17 #include "ui/views/controls/label.h" 20 #include "ui/views/controls/label.h"
18 #include "ui/views/controls/textfield/textfield.h" 21 #include "ui/views/controls/textfield/textfield.h"
(...skipping 435 matching lines...) Expand 10 before | Expand all | Expand 10 after
454 id ax_node = A11yElementAtMidpoint(); 457 id ax_node = A11yElementAtMidpoint();
455 EXPECT_NSEQ(NSAccessibilityButtonRole, 458 EXPECT_NSEQ(NSAccessibilityButtonRole,
456 AttributeValueAtMidpoint(NSAccessibilityRoleAttribute)); 459 AttributeValueAtMidpoint(NSAccessibilityRoleAttribute));
457 460
458 EXPECT_TRUE([[ax_node accessibilityActionNames] 461 EXPECT_TRUE([[ax_node accessibilityActionNames]
459 containsObject:NSAccessibilityPressAction]); 462 containsObject:NSAccessibilityPressAction]);
460 [ax_node accessibilityPerformAction:NSAccessibilityPressAction]; 463 [ax_node accessibilityPerformAction:NSAccessibilityPressAction];
461 EXPECT_TRUE(view->mouse_was_pressed()); 464 EXPECT_TRUE(view->mouse_was_pressed());
462 } 465 }
463 466
467 // Test text-specific attributes that should not be supported for protected
468 // textfields.
469 TEST_F(NativeWidgetMacAccessibilityTest, ProtectedTextfields) {
470 Textfield* textfield = AddChildTextfield(GetWidgetBounds().size());
471 textfield->SetTextInputType(ui::TEXT_INPUT_TYPE_PASSWORD);
472
473 // Get the Textfield accessibility object.
474 NSPoint midpoint = gfx::ScreenPointToNSPoint(GetWidgetBounds().CenterPoint());
475 id ax_node = [widget()->GetNativeWindow() accessibilityHitTest:midpoint];
476 EXPECT_TRUE(ax_node);
477
478 // Create a native Cocoa NSSecureTextField to compare against.
479 base::scoped_nsobject<NSSecureTextField> cocoa_secure_textfield(
480 [[NSSecureTextField alloc] initWithFrame:NSMakeRect(0, 0, 10, 10)]);
481
482 NSArray* views_attributes = [ax_node accessibilityAttributeNames];
483 NSArray* cocoa_attributes =
484 [cocoa_secure_textfield accessibilityAttributeNames];
485
486 NSArray* const expected_supported_attributes = @[
487 NSAccessibilityValueAttribute, NSAccessibilityPlaceholderValueAttribute
488 ];
489 NSArray* const expected_unsupported_attributes = @[
490 NSAccessibilitySelectedTextAttribute,
491 NSAccessibilitySelectedTextRangeAttribute,
492 NSAccessibilityNumberOfCharactersAttribute,
493 NSAccessibilityVisibleCharacterRangeAttribute,
494 NSAccessibilityInsertionPointLineNumberAttribute
495 ];
496
497 for (NSString* attribute_name in expected_supported_attributes) {
498 SCOPED_TRACE(base::SysNSStringToUTF8([NSString
499 stringWithFormat:@"Missing attribute is: %@", attribute_name]));
500 EXPECT_TRUE([views_attributes containsObject:attribute_name]);
501 }
502 if (base::mac::IsAtLeastOS10_10()) {
503 // Check Cocoa's attribute values for PlaceHolder and Value here separately
504 // - these are using the new NSAccessibility protocol.
505 EXPECT_TRUE([cocoa_secure_textfield
506 isAccessibilitySelectorAllowed:@selector(
507 accessibilityPlaceholderValue)]);
508 EXPECT_TRUE([cocoa_secure_textfield
509 isAccessibilitySelectorAllowed:@selector(accessibilityValue)]);
510 }
511
512 EXPECT_FALSE(
513 [ax_node accessibilityIsAttributeSettable:NSAccessibilityValueAttribute]);
514
515 for (NSString* attribute_name in expected_unsupported_attributes) {
516 SCOPED_TRACE(base::SysNSStringToUTF8([NSString
517 stringWithFormat:@"Missing attribute is: %@", attribute_name]));
518 EXPECT_FALSE([views_attributes containsObject:attribute_name]);
519 EXPECT_FALSE([cocoa_attributes containsObject:attribute_name]);
520 }
521 }
522
464 } // namespace views 523 } // namespace views
OLDNEW
« no previous file with comments | « ui/accessibility/platform/ax_platform_node_mac.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698