Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Unified Diff: components/signin/core/browser/signin_metrics.h

Issue 270673003: UMA metrics - number of accounts per profile and account reconciler. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Signin Metrics becomes a namespace; formatting nits Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/signin/core/browser/signin_metrics.h
diff --git a/components/signin/core/browser/signin_metrics.h b/components/signin/core/browser/signin_metrics.h
new file mode 100644
index 0000000000000000000000000000000000000000..e2af6b089270529882fbd8f784984d302942e01c
--- /dev/null
+++ b/components/signin/core/browser/signin_metrics.h
@@ -0,0 +1,32 @@
+// Copyright (c) 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COMPONENTS_SIGNIN_CORE_BROWSER_SIGNIN_METRICS_H_
+#define COMPONENTS_SIGNIN_CORE_BROWSER_SIGNIN_METRICS_H_
+
+#include <stddef.h>
Alexei Svitkine (slow) 2014/05/08 14:39:29 Nit: I don't think this is needed.
Mike Lerman 2014/05/08 18:23:14 Done.
+
+namespace signin_metrics {
Alexei Svitkine (slow) 2014/05/08 14:39:29 Nit: Add an empty line after this.
Mike Lerman 2014/05/08 18:23:14 Done.
+ // Log to UMA histograms and UserCounts stats about a single execution of the
+ // AccountReconciler.
+ // |total_number_accounts| - How many accounts are in the browser for this
+ // profile.
+ // |count_added_to_cookie_jar| - How many accounts were in the browser but not
+ // the cookie jar.
+ // |count_added_to_token| - How may accounts were in the cookie jar but not in
+ // the browser.
+ // |primary_accounts_same| - False if the primary account for the cookie jar
+ // and the token service were different; else true.
+ // |is_first_reconcile| - True if these stats are from the first execution of
+ // the AccountReconcilor.
+ void LogSigninAccountReconciliation(int total_number_accounts,
Alexei Svitkine (slow) 2014/05/08 14:39:29 Nit: Don't indent in a namespace.
Mike Lerman 2014/05/08 18:23:14 Done.
+ int count_added_to_cookie_jar,
+ int count_added_to_token,
+ bool primary_accounts_same,
+ bool is_first_reconcile);
+
+} // namespace signin_metrics
+
+
+#endif // COMPONENTS_SIGNIN_CORE_BROWSER_SIGNIN_METRICS_H_

Powered by Google App Engine
This is Rietveld 408576698