components/signin/core/browser/signin_metrics.h - Issue 270673003: UMA metrics - number of accounts per profile and account reconciler.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/signin/core/browser/signin_metrics.h

Issue 270673003: UMA metrics - number of accounts per profile and account reconciler. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Initial Upload - Metrics, Account Reconciler and UMA configs Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« components/signin/core/browser/account_reconcilor.cc ('K') | « components/signin/core/browser/account_reconcilor.cc ('k') | components/signin/core/browser/signin_metrics.cc » ('j') | components/signin/core/browser/signin_metrics.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright (c) 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef COMPONENTS_SIGNIN_CORE_BROWSER_SIGNIN_METRICS_H_

	6 #define COMPONENTS_SIGNIN_CORE_BROWSER_SIGNIN_METRICS_H_

	7

	8 #include <stddef.h>

	9 #include <string>

	10

	11 #include "base/basictypes.h"

	12

	13 namespace base {

	14 class FilePath;

	15 }

	16

	17 class SigninMetrics {

	18 public:

	19 static void LogSigninAccountReconciliation(int total_number_accounts,
	Roger Tawa OOO till Jul 10th 2014/05/07 17:05:38 Should have a comment describing what this functio Should have a comment describing what this function does and what the arguments mean. In header files its probably better to list each arg on its own line when they don't fit the 80 char limit. Mike Lerman 2014/05/07 18:49:37 Done. Show quoted text On 2014/05/07 17:05:38, Roger Tawa wrote: > Should have a comment describing what this function does and what the arguments > mean. In header files its probably better to list each arg on its own line when > they don't fit the 80 char limit. Done.
	20 int count_added_to_cookie_jar, int count_added_to_token,

	21 bool primary_accounts_same, bool is_first_reconcile);

	22 };
	Roger Tawa OOO till Jul 10th 2014/05/07 17:05:38 New code should not use classes that to define a s New code should not use classes that to define a scope for static functions. Better to wrap the function in a namespace like signin_metrics. Mike Lerman 2014/05/07 18:49:37 Done. Show quoted text On 2014/05/07 17:05:38, Roger Tawa wrote: > New code should not use classes that to define a scope for static functions. > Better to wrap the function in a namespace like signin_metrics. Done.
	23

	24

	25 #endif // COMPONENTS_SIGNIN_CORE_BROWSER_SIGNIN_METRICS_H_

OLD	NEW