Mark elements as viewport constrained when they become sticky positioned

third_party/WebKit/Source/core/frame/FrameViewTest.cpp

Index: third_party/WebKit/Source/core/frame/FrameViewTest.cpp
diff --git a/third_party/WebKit/Source/core/frame/FrameViewTest.cpp b/third_party/WebKit/Source/core/frame/FrameViewTest.cpp
index a3f1cd19c6e9c4b71b5a3ca9f9483e5834121f6e..5fdaa429eb9e675bd4ee469363b1c2d619ca0b34 100644
--- a/third_party/WebKit/Source/core/frame/FrameViewTest.cpp
+++ b/third_party/WebKit/Source/core/frame/FrameViewTest.cpp
@@ -4,9 +4,11 @@
 
 #include "core/frame/FrameView.h"
 
+#include <memory>

[flackr, 2017/02/22 14:45:42]

I think convention is also to have a blank line between system includes and
project includes.

[smcgruer, 2017/02/22 15:26:32]

Done.

 #include "bindings/core/v8/ExceptionState.h"
 #include "core/frame/Settings.h"
 #include "core/html/HTMLElement.h"
+#include "core/layout/LayoutBoxModelObject.h"
 #include "core/layout/LayoutObject.h"
 #include "core/loader/EmptyClients.h"
 #include "core/page/Page.h"
@@ -18,7 +20,6 @@
 #include "platform/testing/RuntimeEnabledFeaturesTestHelpers.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
-#include <memory>
 
 using testing::_;
 using testing::AnyNumber;
@@ -137,5 +138,40 @@ TEST_P(FrameViewTest, NoOverflowInIncrementVisuallyNonEmptyPixelCount) {
   EXPECT_TRUE(document().view()->isVisuallyNonEmpty());
 }
 
+TEST_P(FrameViewTest, StyleChangeUpdatesViewportConstrainedObjects) {
+  // When using root layer scrolling there is no concept of viewport constrained
+  // objects, so skip this test.
+  if (RuntimeEnabledFeatures::rootLayerScrollingEnabled())
+    return;
+
+  document().body()->setInnerHTML(
+      "<style>.container { height: 200%; }"
+      "#sticky { position: sticky; top: 0; height: 50px; }</style>"
+      "<div class='container'><div id='sticky'></div></div>");
+  document().view()->updateAllLifecyclePhases();
+
+  LayoutBoxModelObject* sticky = toLayoutBoxModelObject(
+      document().getElementById("sticky")->layoutObject());
+
+  EXPECT_TRUE(
+      document().view()->viewportConstrainedObjects()->contains(sticky));
+
+  // Making the element non-sticky should remove it from the set of
+  // viewport-constrained objects.
+  document().getElementById("sticky")->setAttribute(HTMLNames::styleAttr,
+                                                    "position: relative");
+  document().view()->updateAllLifecyclePhases();
+
+  EXPECT_FALSE(
+      document().view()->viewportConstrainedObjects()->contains(sticky));
+
+  // And making it sticky again should put it back in that list.
+  document().getElementById("sticky")->setAttribute(HTMLNames::styleAttr, "");
+  document().view()->updateAllLifecyclePhases();
+
+  EXPECT_TRUE(
+      document().view()->viewportConstrainedObjects()->contains(sticky));
+}
+
 }  // namespace
 }  // namespace blink