third_party/WebKit/Source/devtools/front_end/timeline/TimelineNetworkFlameChart.js - Issue 2706643002: DevTools: Move network request instrumentation points for timeline down the stack.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelineNetworkFlameChart.js

Issue 2706643002: DevTools: Move network request instrumentation points for timeline down the stack. (Closed)

Patch Set: . Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/devtools/front_end/timeline/TimelineNetworkFlameChart.js

diff --git a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineNetworkFlameChart.js b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineNetworkFlameChart.js

index d066c156a6561e53b67bd5dd90fd8dcaf28f252f..7a2747fc24fd3566a3c27d3092eb22f2a7652d29 100644

--- a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineNetworkFlameChart.js

+++ b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineNetworkFlameChart.js

@@ -227,7 +227,8 @@ Timeline.TimelineFlameChartNetworkDataProvider = class {

var lineY = Math.floor(barY + barHeight / 2) + 0.5;

var leftTick = Math.floor(unclippedBarX) + 0.5;

var rightTick = end - 0.5;

- drawTick(leftTick, sendStart, lineY);

+ if (request.startTime)

+ drawTick(leftTick, sendStart, lineY);

drawTick(rightTick, finish, lineY);

context.stroke();

« no previous file with comments | « third_party/WebKit/Source/core/loader/PingLoader.cpp ('k') | third_party/WebKit/Source/platform/BUILD.gn » ('j') | no next file with comments »