Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelineNetworkFlameChart.js

Issue 2706643002: DevTools: Move network request instrumentation points for timeline down the stack. (Closed)
Patch Set: addressing comment Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @implements {PerfUI.FlameChartDataProvider} 6 * @implements {PerfUI.FlameChartDataProvider}
7 * @unrestricted 7 * @unrestricted
8 */ 8 */
9 Timeline.TimelineFlameChartNetworkDataProvider = class { 9 Timeline.TimelineFlameChartNetworkDataProvider = class {
10 constructor() { 10 constructor() {
(...skipping 209 matching lines...) Expand 10 before | Expand all | Expand 10 after
220 context.lineTo(begin, y + tickHeightPx / 2); 220 context.lineTo(begin, y + tickHeightPx / 2);
221 context.moveTo(begin, y); 221 context.moveTo(begin, y);
222 context.lineTo(end, y); 222 context.lineTo(end, y);
223 } 223 }
224 224
225 context.lineWidth = 1; 225 context.lineWidth = 1;
226 context.strokeStyle = '#ccc'; 226 context.strokeStyle = '#ccc';
227 var lineY = Math.floor(barY + barHeight / 2) + 0.5; 227 var lineY = Math.floor(barY + barHeight / 2) + 0.5;
228 var leftTick = Math.floor(unclippedBarX) + 0.5; 228 var leftTick = Math.floor(unclippedBarX) + 0.5;
229 var rightTick = end - 0.5; 229 var rightTick = end - 0.5;
230 drawTick(leftTick, sendStart, lineY); 230 if (request.startTime)
231 drawTick(leftTick, sendStart, lineY);
231 drawTick(rightTick, finish, lineY); 232 drawTick(rightTick, finish, lineY);
232 context.stroke(); 233 context.stroke();
233 234
234 if (typeof request.priority === 'string') { 235 if (typeof request.priority === 'string') {
235 var color = this._colorForPriority(request.priority); 236 var color = this._colorForPriority(request.priority);
236 if (color) { 237 if (color) {
237 context.fillStyle = color; 238 context.fillStyle = color;
238 context.fillRect(sendStart + 0.5, barY + 0.5, 3.5, 3.5); 239 context.fillRect(sendStart + 0.5, barY + 0.5, 3.5, 3.5);
239 } 240 }
240 } 241 }
(...skipping 145 matching lines...) Expand 10 before | Expand all | Expand 10 after
386 387
387 /** 388 /**
388 * @override 389 * @override
389 * @param {number} entryIndex 390 * @param {number} entryIndex
390 * @return {boolean} 391 * @return {boolean}
391 */ 392 */
392 canJumpToEntry(entryIndex) { 393 canJumpToEntry(entryIndex) {
393 return false; 394 return false;
394 } 395 }
395 }; 396 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698