Refactor a copy of dartium/buildbot_annotated_steps.py

tools/dartium/multivm_archive.py

+#!/usr/bin/python
+
+# Copyright (c) 2014 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+"""Archive builds from the multivm and dartium perf builders

[ricow1, 2014/05/14 17:28:18]

does this really get called for dartium perf builders?

[Bill Hesse, 2014/05/15 10:46:37]

Yes, since the setup is identical for multivm and dartium, it will be easier to
maintain, and the download code for both will be identical.  If we know we have
a different builder for dartium, that uploads the binary we want, then we can
drop this later.

+
+Archive dartium, content_shell, and chromedriver to the old cloud storage bucket
+gs://dartium-archive.
+"""
+
+import os
+import platform
+import re
+import subprocess
+import sys
+
+import upload_steps
+import utils
+
+SRC_PATH = os.path.dirname(

[ricow1, 2014/05/14 17:28:18]

how about putting this in utils and using it here and in the
buildbot_annotated_steps instead of replicating it?

[Bill Hesse, 2014/05/15 10:46:37]

Done.  But:

The file utils.py contains only totally general python utility functions, not
specific to dart or dartium at all.  If we add a function to it that is specific
to the location of the file, we should at least make a new section at the bottom
of "local site-specific changes".
Also, this function is only valid inside a dart checkout that is inside a
dartium checkout.  If the function is called inside a regular dart checkout, it
will return the directory containing the dart checkout.

+           os.path.dirname(
+           os.path.dirname(
+           os.path.dirname(os.path.abspath(__file__)))))
+
+def main():
+  multivm_deps = os.path.join(os.path.dirname(SRC_PATH), 'multivm.deps')
+  revision_directory = (multivm_deps if (os.path.isdir(multivm_deps))
+                           else os.path.join(SRC_PATH, 'dart'))
+  output, _ = subprocess.Popen(['svn', 'info'],
+                               stdout=subprocess.PIPE,
+                               stderr=subprocess.STDOUT,
+                               shell=(platform.system == 'Windows'),
+                               cwd = revision_directory).communicate()
+  revision = re.search('Last Changed Rev: (\d+)', output).group(1)
+  version = revision + '.0'
+  info = upload_steps.BuildInfo(version, revision)
+
+  # Archive to the revision bucket unless integration build

[ricow1, 2014/05/14 17:28:18]

what does integration build mean here?

[Bill Hesse, 2014/05/15 10:46:37]

Stray comment - fixed.

+  if info.is_build:
+    upload_steps.ArchiveAndUpload(info, archive_latest=False)
+
+if __name__ == '__main__':
+  sys.exit(main())