Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 270663002: Implemented profile-aware owner key loading. (Closed)

Created:
6 years, 7 months ago by ygorshenin1
Modified:
6 years, 7 months ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

Implemented profile-aware owner key loading. BUG=230018 TEST=manual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271802

Patch Set 1 #

Patch Set 2 : Fixed mocks. #

Patch Set 3 : Fixed DeviceSettignsService unit_tests. #

Patch Set 4 : Fixed key loading flow. #

Patch Set 5 : Fixed DeviceOAuth2TokenServiceTest.* unit_tests. #

Total comments: 7

Patch Set 6 : Added OwnerKeyReloader. #

Patch Set 7 : Fixes to tests. #

Patch Set 8 : Fixes. #

Total comments: 7

Patch Set 9 : Implemented OwnerKeyReloaderService. #

Patch Set 10 : Fixed tests. #

Total comments: 19

Patch Set 11 : Fixes. #

Total comments: 8

Patch Set 12 : Restored OwnerSettingsServiceFactory::SetUsername() API. #

Patch Set 13 : Small fix: removed redundant check. #

Total comments: 6

Patch Set 14 : Fixes. #

Total comments: 18

Patch Set 15 : Fixes, rebase. #

Total comments: 12

Patch Set 16 : Fixes, rebase. #

Patch Set 17 : Fixed tests, used GetPublicSlotForChromeOSUSer. #

Total comments: 10

Patch Set 18 : Fixes, rebase. #

Total comments: 1

Patch Set 19 : Fixes, rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+462 lines, -57 lines) Patch
M chrome/browser/chromeos/login/auth/parallel_authenticator.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/users/user_manager_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 2 chunks +3 lines, -4 lines 0 comments Download
A chrome/browser/chromeos/ownership/owner_settings_service.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 1 chunk +51 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/ownership/owner_settings_service.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +72 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/ownership/owner_settings_service_factory.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +60 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/ownership/owner_settings_service_factory.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +77 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/policy/login_screen_default_policy_browsertest.cc View 1 2 3 4 5 6 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/policy/power_policy_browsertest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/settings/device_settings_provider_unittest.cc View 1 2 3 4 5 2 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/settings/device_settings_service.h View 1 2 3 4 5 3 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/chromeos/settings/device_settings_service.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +13 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/settings/device_settings_service_unittest.cc View 1 2 3 4 5 7 chunks +21 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/settings/mock_owner_key_util.h View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/settings/mock_owner_key_util.cc View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/settings/owner_key_util.h View 1 2 3 4 5 3 chunks +14 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/settings/owner_key_util.cc View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/settings/session_manager_operation.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 4 chunks +8 lines, -1 line 0 comments Download
M chrome/browser/chromeos/settings/session_manager_operation.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 4 chunks +14 lines, -7 lines 0 comments Download
M chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +4 lines, -0 lines 0 comments Download
M crypto/rsa_private_key.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 2 chunks +18 lines, -0 lines 0 comments Download
M crypto/rsa_private_key_nss.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 4 chunks +73 lines, -28 lines 0 comments Download

Messages

Total messages: 37 (0 generated)
ygorshenin1
6 years, 7 months ago (2014-05-12 07:59:52 UTC) #1
Mattias Nissler (ping if slow)
https://codereview.chromium.org/270663002/diff/70001/chrome/browser/chromeos/settings/device_settings_service.cc File chrome/browser/chromeos/settings/device_settings_service.cc (right): https://codereview.chromium.org/270663002/diff/70001/chrome/browser/chromeos/settings/device_settings_service.cc#newcode296 chrome/browser/chromeos/settings/device_settings_service.cc:296: Profile* profile = content::Source<Profile>(source).ptr(); chrome/browser/chromeos/settings deliberately doesn't know or ...
6 years, 7 months ago (2014-05-12 08:26:43 UTC) #2
ygorshenin1
https://codereview.chromium.org/270663002/diff/70001/chrome/browser/chromeos/settings/device_settings_service.cc File chrome/browser/chromeos/settings/device_settings_service.cc (right): https://codereview.chromium.org/270663002/diff/70001/chrome/browser/chromeos/settings/device_settings_service.cc#newcode296 chrome/browser/chromeos/settings/device_settings_service.cc:296: Profile* profile = content::Source<Profile>(source).ptr(); You mean to directly pass ...
6 years, 7 months ago (2014-05-12 08:35:43 UTC) #3
Mattias Nissler (ping if slow)
https://codereview.chromium.org/270663002/diff/70001/chrome/browser/chromeos/settings/device_settings_service.cc File chrome/browser/chromeos/settings/device_settings_service.cc (right): https://codereview.chromium.org/270663002/diff/70001/chrome/browser/chromeos/settings/device_settings_service.cc#newcode296 chrome/browser/chromeos/settings/device_settings_service.cc:296: Profile* profile = content::Source<Profile>(source).ptr(); On 2014/05/12 08:35:43, ygorshenin1 wrote: ...
6 years, 7 months ago (2014-05-12 08:40:30 UTC) #4
ygorshenin1
https://codereview.chromium.org/270663002/diff/70001/chrome/browser/chromeos/settings/device_settings_service.cc File chrome/browser/chromeos/settings/device_settings_service.cc (right): https://codereview.chromium.org/270663002/diff/70001/chrome/browser/chromeos/settings/device_settings_service.cc#newcode296 chrome/browser/chromeos/settings/device_settings_service.cc:296: Profile* profile = content::Source<Profile>(source).ptr(); On 2014/05/12 08:40:31, Mattias Nissler ...
6 years, 7 months ago (2014-05-12 08:56:54 UTC) #5
Mattias Nissler (ping if slow)
On 2014/05/12 08:56:54, ygorshenin1 wrote: > https://codereview.chromium.org/270663002/diff/70001/chrome/browser/chromeos/settings/device_settings_service.cc > File chrome/browser/chromeos/settings/device_settings_service.cc (right): > > https://codereview.chromium.org/270663002/diff/70001/chrome/browser/chromeos/settings/device_settings_service.cc#newcode296 > ...
6 years, 7 months ago (2014-05-12 09:03:20 UTC) #6
ygorshenin1
PTAL https://codereview.chromium.org/270663002/diff/70001/chrome/browser/chromeos/settings/device_settings_service.cc File chrome/browser/chromeos/settings/device_settings_service.cc (right): https://codereview.chromium.org/270663002/diff/70001/chrome/browser/chromeos/settings/device_settings_service.cc#newcode296 chrome/browser/chromeos/settings/device_settings_service.cc:296: Profile* profile = content::Source<Profile>(source).ptr(); All User/Profile-related things are ...
6 years, 7 months ago (2014-05-13 09:46:13 UTC) #7
ygorshenin1
+ Nikita
6 years, 7 months ago (2014-05-13 10:51:59 UTC) #8
Mattias Nissler (ping if slow)
This looks much better already. I'm still a bit unclear on whether we're on the ...
6 years, 7 months ago (2014-05-13 11:55:53 UTC) #9
Nikita (slow)
https://codereview.chromium.org/270663002/diff/130001/chrome/browser/chromeos/login/owner_key_reloader.h File chrome/browser/chromeos/login/owner_key_reloader.h (right): https://codereview.chromium.org/270663002/diff/130001/chrome/browser/chromeos/login/owner_key_reloader.h#newcode17 chrome/browser/chromeos/login/owner_key_reloader.h:17: class OwnerKeyReloader : public content::NotificationObserver { On 2014/05/13 11:55:53, ...
6 years, 7 months ago (2014-05-13 15:33:05 UTC) #10
Nikita (slow)
6 years, 7 months ago (2014-05-13 15:33:06 UTC) #11
ygorshenin1
PTAL https://codereview.chromium.org/270663002/diff/130001/chrome/browser/chromeos/login/owner_key_reloader.h File chrome/browser/chromeos/login/owner_key_reloader.h (right): https://codereview.chromium.org/270663002/diff/130001/chrome/browser/chromeos/login/owner_key_reloader.h#newcode17 chrome/browser/chromeos/login/owner_key_reloader.h:17: class OwnerKeyReloader : public content::NotificationObserver { On 2014/05/13 ...
6 years, 7 months ago (2014-05-14 09:10:57 UTC) #12
Mattias Nissler (ping if slow)
I like this version much better, as it's moving us in the right direction. I've ...
6 years, 7 months ago (2014-05-14 12:18:09 UTC) #13
ygorshenin1
PTAL https://codereview.chromium.org/270663002/diff/190001/chrome/browser/chromeos/login/owner_key_reloader_service.cc File chrome/browser/chromeos/login/owner_key_reloader_service.cc (right): https://codereview.chromium.org/270663002/diff/190001/chrome/browser/chromeos/login/owner_key_reloader_service.cc#newcode22 chrome/browser/chromeos/login/owner_key_reloader_service.cc:22: std::string OwnerKeyReloaderService::username_; On 2014/05/14 12:18:10, Mattias Nissler wrote: ...
6 years, 7 months ago (2014-05-14 15:30:07 UTC) #14
Mattias Nissler (ping if slow)
This looks pretty good now. https://codereview.chromium.org/270663002/diff/190001/chrome/browser/chromeos/login/owner_key_reloader_service.cc File chrome/browser/chromeos/login/owner_key_reloader_service.cc (right): https://codereview.chromium.org/270663002/diff/190001/chrome/browser/chromeos/login/owner_key_reloader_service.cc#newcode25 chrome/browser/chromeos/login/owner_key_reloader_service.cc:25: : profile_(profile) { On ...
6 years, 7 months ago (2014-05-14 16:00:36 UTC) #15
ygorshenin1
https://codereview.chromium.org/270663002/diff/210001/chrome/browser/chromeos/login/owner_settings_service.cc File chrome/browser/chromeos/login/owner_settings_service.cc (right): https://codereview.chromium.org/270663002/diff/210001/chrome/browser/chromeos/login/owner_settings_service.cc#newcode31 chrome/browser/chromeos/login/owner_settings_service.cc:31: // OnwerSettinsService construction ProfileIOData is not initialized. On 2014/05/14 ...
6 years, 7 months ago (2014-05-15 08:39:55 UTC) #16
ygorshenin1
PTAL
6 years, 7 months ago (2014-05-15 10:17:04 UTC) #17
Mattias Nissler (ping if slow)
LGTM w/ nits. https://codereview.chromium.org/270663002/diff/250001/chrome/browser/chromeos/login/user_manager_impl.cc File chrome/browser/chromeos/login/user_manager_impl.cc (right): https://codereview.chromium.org/270663002/diff/250001/chrome/browser/chromeos/login/user_manager_impl.cc#newcode1564 chrome/browser/chromeos/login/user_manager_impl.cc:1564: // Owner must be first user ...
6 years, 7 months ago (2014-05-15 11:21:28 UTC) #18
ygorshenin1
Many thanks, Mattias! + mmenke@ for chrome/browser/profiles/* + wtc@ for crypto/* https://codereview.chromium.org/270663002/diff/250001/chrome/browser/chromeos/login/user_manager_impl.cc File chrome/browser/chromeos/login/user_manager_impl.cc (right): ...
6 years, 7 months ago (2014-05-15 11:58:36 UTC) #19
mmenke
I'm only an owner of the profile code that lives on the IO thread.
6 years, 7 months ago (2014-05-15 12:22:07 UTC) #20
ygorshenin1
Sorry, Matt. + davemoore@ for chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.cc
6 years, 7 months ago (2014-05-15 12:30:23 UTC) #21
ygorshenin1
+ wtc@ for crypto/* - mmenke@
6 years, 7 months ago (2014-05-15 12:31:23 UTC) #22
ygorshenin1
6 years, 7 months ago (2014-05-15 12:31:52 UTC) #23
Nikita (slow)
chromeos/login lgtm https://codereview.chromium.org/270663002/diff/270001/chrome/browser/chromeos/login/owner_settings_service.cc File chrome/browser/chromeos/login/owner_settings_service.cc (right): https://codereview.chromium.org/270663002/diff/270001/chrome/browser/chromeos/login/owner_settings_service.cc#newcode26 chrome/browser/chromeos/login/owner_settings_service.cc:26: // ReloadOwnerKey() is called after delay because ...
6 years, 7 months ago (2014-05-15 12:48:57 UTC) #24
Nikita (slow)
I'm splitting chromeos/login code right now (https://codereview.chromium.org/286933002/), can you please move new files to something ...
6 years, 7 months ago (2014-05-15 12:50:54 UTC) #25
Nikita (slow)
On 2014/05/15 12:50:54, Nikita Kostylev wrote: > I'm splitting chromeos/login code right now > (https://codereview.chromium.org/286933002/), ...
6 years, 7 months ago (2014-05-15 13:26:02 UTC) #26
ygorshenin1
PTAL https://codereview.chromium.org/270663002/diff/270001/chrome/browser/chromeos/login/owner_settings_service.cc File chrome/browser/chromeos/login/owner_settings_service.cc (right): https://codereview.chromium.org/270663002/diff/270001/chrome/browser/chromeos/login/owner_settings_service.cc#newcode26 chrome/browser/chromeos/login/owner_settings_service.cc:26: // ReloadOwnerKey() is called after delay because at ...
6 years, 7 months ago (2014-05-16 12:09:36 UTC) #27
wtc
Patch set 15: src/crypto LGTM. https://codereview.chromium.org/270663002/diff/290001/crypto/rsa_private_key.h File crypto/rsa_private_key.h (right): https://codereview.chromium.org/270663002/diff/290001/crypto/rsa_private_key.h#newcode211 crypto/rsa_private_key.h:211: // half in a ...
6 years, 7 months ago (2014-05-16 15:06:35 UTC) #28
ygorshenin1
Many thanks, wtc@. Dave, could you please take a look? https://codereview.chromium.org/270663002/diff/290001/crypto/rsa_private_key.h File crypto/rsa_private_key.h (right): https://codereview.chromium.org/270663002/diff/290001/crypto/rsa_private_key.h#newcode211 ...
6 years, 7 months ago (2014-05-19 09:43:49 UTC) #29
wtc
Patch set 17: src/crypto LGTM. https://codereview.chromium.org/270663002/diff/330001/crypto/rsa_private_key.h File crypto/rsa_private_key.h (right): https://codereview.chromium.org/270663002/diff/330001/crypto/rsa_private_key.h#newcode215 crypto/rsa_private_key.h:215: // is created in ...
6 years, 7 months ago (2014-05-19 17:23:53 UTC) #30
ygorshenin1
https://codereview.chromium.org/270663002/diff/330001/crypto/rsa_private_key.h File crypto/rsa_private_key.h (right): https://codereview.chromium.org/270663002/diff/330001/crypto/rsa_private_key.h#newcode215 crypto/rsa_private_key.h:215: // is created in the key slot. On 2014/05/19 ...
6 years, 7 months ago (2014-05-20 07:53:49 UTC) #31
DaveMoore
User lgtm
6 years, 7 months ago (2014-05-20 16:25:18 UTC) #32
wtc
Patch set 18: src/crypto LGTM. Thanks. https://codereview.chromium.org/270663002/diff/330001/crypto/rsa_private_key_nss.cc File crypto/rsa_private_key_nss.cc (right): https://codereview.chromium.org/270663002/diff/330001/crypto/rsa_private_key_nss.cc#newcode52 crypto/rsa_private_key_nss.cc:52: // takes ownership ...
6 years, 7 months ago (2014-05-20 16:46:38 UTC) #33
ygorshenin1
Many thanks to everybody! https://codereview.chromium.org/270663002/diff/330001/crypto/rsa_private_key_nss.cc File crypto/rsa_private_key_nss.cc (right): https://codereview.chromium.org/270663002/diff/330001/crypto/rsa_private_key_nss.cc#newcode52 crypto/rsa_private_key_nss.cc:52: // takes ownership of the ...
6 years, 7 months ago (2014-05-20 17:01:33 UTC) #34
ygorshenin1
The CQ bit was checked by ygorshenin@chromium.org
6 years, 7 months ago (2014-05-20 17:03:14 UTC) #35
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ygorshenin@chromium.org/270663002/360001
6 years, 7 months ago (2014-05-20 17:03:40 UTC) #36
commit-bot: I haz the power
6 years, 7 months ago (2014-05-21 01:50:28 UTC) #37
Message was sent while issue was closed.
Change committed as 271802

Powered by Google App Engine
This is Rietveld 408576698